<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Jan 16, 2018 at 11:35 PM, Samuel Iglesias Gonsálvez <span dir="ltr"><<a href="mailto:siglesias@igalia.com" target="_blank">siglesias@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by: Samuel Iglesias Gonsálvez <<a href="mailto:siglesias@igalia.com">siglesias@igalia.com</a>><br>
---<br>
src/intel/vulkan/anv_image.c | 6 ++----<br>
1 file changed, 2 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_image.c b/src/intel/vulkan/anv_image.c<br>
index 4d13e05e11f..72e408764d8 100644<br>
--- a/src/intel/vulkan/anv_image.c<br>
+++ b/src/intel/vulkan/anv_image.c<br>
@@ -335,10 +335,8 @@ make_surface(const struct anv_device *dev,<br>
.usage = usage,<br>
.tiling_flags = tiling_flags);<br>
<br>
- /* isl_surf_init() will fail only if provided invalid input. Invalid input<br>
- * is illegal in Vulkan.<br>
- */<br>
- assert(ok);<br>
+ if (!ok)<br>
+ return VK_ERROR_OUT_OF_DEVICE_MEMORY;<br></blockquote><div><br></div><div>This looks fine. It might be worth adding a comment saying why we're doing this. Unfortunately, the new spec text hasn't appeared publically yet. In any case</div><div><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>></div><div><br></div><div>In order to solve the longer-term problem of just having a single bool returned by isl_surf_init_s, I can think of a few different solutions:</div><div><br></div><div> 1) Move the max size check out of isl_surf_init and have a max size in the isl_device and require the driver to do the check.</div><div> 2) Add a new ISL enum for error codes so we can be more descriptive.</div><div><br></div><div>All in all, I'm not too worried about it at the moment.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
image->planes[plane].aux_usage = ISL_AUX_USAGE_NONE;<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.14.1<br>
<br>
</font></span></blockquote></div><br></div></div>