<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote"><div>Hi Emil, Greg,</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">> (Needs CPU topology detection to actually work)<br></blockquote><div><br></div><div>Does it? Or does it just need the topology detection for the current "default" behavior for thread placement? The default behavior for swr is to use the cpu topology info to place one thread per core and pin it to that core. However, if you instead set the env var KNOB_MAX_WORKER_THREADS=N, it will use a thread pool of N threads with no regard to CPU topology (this is actually the mode I typically use it in actually for HPC environments where we run multiple processes per node).<br></div><div> </div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
IMHO it might be better to drop the patch, until its actually working.<br>
There's little point in building it if one cannot use it.<br></blockquote><div><br></div><div>I would suggest instead of going through the hoops to determine
topology, simply disable or ignore the topology settings on FreeBSD and
just use the floating thread-pool configuration exclusively.</div><div><br></div><div><br></div><div>- Chuck</div></div></div></div>