<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="https://bugs.freedesktop.org/show_bug.cgi?id=104553#c8">Comment # 8</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="https://bugs.freedesktop.org/show_bug.cgi?id=104553">bug 104553</a> from <a class="email" href="mailto:imirkin@alum.mit.edu" title="Ilia Mirkin <imirkin@alum.mit.edu>"> Ilia Mirkin</a> <pre>FYI idr had a separate script to reduce the giant test cases to the smallest that would still fail. It should be in one of his piglit branches in his personal fd.o git repo. (I'm on the go, hence no specific URL.) On Jan 22, 2018 09:02, <<a href="mailto:bugzilla-daemon@freedesktop.org">bugzilla-daemon@freedesktop.org</a>> wrote: > <a href="mailto:florian.will@googlemail.com">florian.will@googlemail.com</a> changed <a class="bz_bug_link bz_status_NEW " title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="show_bug.cgi?id=104553">bug 104553</a> > <<a class="bz_bug_link bz_status_NEW " title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="show_bug.cgi?id=104553">https://bugs.freedesktop.org/show_bug.cgi?id=104553</a>> > What Removed Added > <a href="attachment.cgi?id=136630" name="attach_136630" title="Failing piglit test (when test_variant = 2) for this bug.">Attachment #136630</a> <a href="attachment.cgi?id=136630&action=edit" title="Failing piglit test (when test_variant = 2) for this bug.">[details]</a> is obsolete 1 > > *<a href="show_bug.cgi?id=104553#c7">Comment # 7</a> <<a class="bz_bug_link bz_status_NEW " title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="show_bug.cgi?id=104553#c7">https://bugs.freedesktop.org/show_bug.cgi?id=104553#c7</a>> on > <a class="bz_bug_link bz_status_NEW " title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="show_bug.cgi?id=104553">bug 104553</a> <<a class="bz_bug_link bz_status_NEW " title="NEW - mat4: m[i][j] incorrect result with row_major UBO" href="show_bug.cgi?id=104553">https://bugs.freedesktop.org/show_bug.cgi?id=104553</a>> from > <a href="mailto:florian.will@googlemail.com">florian.will@googlemail.com</a> <<a href="mailto:florian.will@googlemail.com">florian.will@googlemail.com</a>> * > > Created <a href="attachment.cgi?id=136878" name="attach_136878" title="Changes to piglit UBO test generator">attachment 136878</a> <a href="attachment.cgi?id=136878&action=edit" title="Changes to piglit UBO test generator">[details]</a> <a href='page.cgi?id=splinter.html&bug=104553&attachment=136878'>[review]</a> <<a href="https://bugs.freedesktop.org/attachment.cgi?id=136878">https://bugs.freedesktop.org/attachment.cgi?id=136878</a>> [details] <<a href="https://bugs.freedesktop.org/attachment.cgi?id=136878&action=edit">https://bugs.freedesktop.org/attachment.cgi?id=136878&action=edit</a>> [review] <<a href="https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=104553&attachment=136878">https://bugs.freedesktop.org/page.cgi?id=splinter.html&bug=104553&attachment=136878</a>> > Changes to piglit UBO test generator > > I have now extended the random UBO piglit test generator python script (in a > hackish way) to generate SSBO tests as well, and added std430 packing rules to > generate std430 SSBO tests. My changes are in the attached patch file, but I'd > say it's not suitable for piglit git (too ugly). > > It was helpful to validate the mesa patch I've attached to this bug report > earlier. Using mesa git master, 391 out of the 540 generated UBO&SSBO tests > fail. After applying my patch, only a few tests (3-7) fail. The failing tests > are always very huge test files (some have more than 10k lines and sometimes up > to 5MB shader_test files). Apparently they hit something like an internal size > limit for vertex shaders, because the tests pass when commenting out one half > of the test conditions in the vertex shader, and they still pass when > commenting out the other half of the vertex shader. > > So I'm now fairly confident that my patch improves the SSBO / UBO buffer access > behaviour when reading from SSBOs and UBOs. > > Is there anything else that should be tested? Or any comments about the patch > by someone who knows the lower_buffer_access code better than I do? > > ------------------------------ > You are receiving this mail because: > > - You are the assignee for the bug. > > > _______________________________________________ > mesa-dev mailing list > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> > ></pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the assignee for the bug.</li> </ul> </body> </html>