<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Jan 22, 2018 at 2:24 AM, Pohjolainen, Topi <span dir="ltr"><<a href="mailto:topi.pohjolainen@gmail.com" target="_blank">topi.pohjolainen@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">On Fri, Jan 19, 2018 at 03:47:36PM -0800, Jason Ekstrand wrote:<br>
> ---<br>
> src/intel/vulkan/genX_cmd_<wbr>buffer.c | 34 +++++++++++++++++++-----------<wbr>----<br>
> 1 file changed, 19 insertions(+), 15 deletions(-)<br>
><br>
> diff --git a/src/intel/vulkan/genX_cmd_<wbr>buffer.c b/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
> index 9e2eba3..15e805f 100644<br>
> --- a/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
> +++ b/src/intel/vulkan/genX_cmd_<wbr>buffer.c<br>
> @@ -431,6 +431,25 @@ genX(set_image_needs_resolve)(<wbr>struct anv_cmd_buffer *cmd_buffer,<br>
> }<br>
> }<br>
><br>
> +#if GEN_IS_HASWELL || GEN_GEN >= 8<br>
> +static inline uint32_t<br>
> +mi_alu(uint32_t opcode, uint32_t operand1, uint32_t operand2)<br>
> +{<br>
> + struct GENX(MI_MATH_ALU_INSTRUCTION) instr = {<br>
> + .ALUOpcode = opcode,<br>
> + .Operand1 = operand1,<br>
> + .Operand2 = operand2,<br>
> + };<br>
> +<br>
> + uint32_t dw;<br>
> + GENX(MI_MATH_ALU_INSTRUCTION_<wbr>pack)(NULL, &dw, &instr);<br>
> +<br>
> + return dw;<br>
> +}<br>
> +#endif<br>
> +<br>
> +#define CS_GPR(n) (0x2600 + (n) * 8)<br>
> +<br>
> static void<br>
> genX(load_needs_resolve_<wbr>predicate)(struct anv_cmd_buffer *cmd_buffer,<br>
> const struct anv_image *image,<br>
> @@ -2312,21 +2331,6 @@ void genX(CmdDrawIndexed)(<br>
> /* MI_MATH only exists on Haswell+ */<br>
> #if GEN_IS_HASWELL || GEN_GEN >= 8<br>
><br>
> -static uint32_t<br>
> -mi_alu(uint32_t opcode, uint32_t op1, uint32_t op2)<br>
> -{<br>
> - struct GENX(MI_MATH_ALU_INSTRUCTION) instr = {<br>
> - .ALUOpcode = opcode,<br>
> - .Operand1 = op1,<br>
> - .Operand2 = op2,<br>
> - };<br>
> -<br>
> - uint32_t dw;<br>
> - GENX(MI_MATH_ALU_INSTRUCTION_<wbr>pack)(NULL, &dw, &instr);<br>
> -<br>
> - return dw;<br>
> -}<br>
> -<br>
> #define CS_GPR(n) (0x2600 + (n) * 8)<br>
<br>
</div></div>This needs to be removed as well. With that:<br></blockquote><div><br></div><div>Done.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Reviewed-by: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a>><br>
<span class=""><br>
><br>
> /* Emit dwords to multiply GPR0 by N */<br>
> --<br>
> 2.5.0.400.gff86faf<br>
><br>
</span>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>