<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> <style type="text/css" style="display:none;"></style> </head> <body dir="ltr"> <div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr"> <p style="margin-top:0;margin-bottom:0">Reviewed-by: Neha Bhende<bhenden@vmware.com><br> </p> <p style="margin-top:0;margin-bottom:0"><br> </p> <div id="Signature"> <div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255); font-family: Calibri, Arial, Helvetica, sans-serif, "EmojiFont", "Apple Color Emoji", "Segoe UI Emoji", NotoColorEmoji, "Segoe UI Symbol", "Android Emoji", EmojiSymbols;"> <p>Regards,</p> <p>Neha<br> </p> </div> </div> </div> <hr style="display:inline-block;width:98%" tabindex="-1"> <div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Brian Paul <brianp@vmware.com><br> <b>Sent:</b> Thursday, January 25, 2018 4:29:05 PM<br> <b>To:</b> mesa-dev@lists.freedesktop.org<br> <b>Cc:</b> Charmaine Lee; Neha Bhende<br> <b>Subject:</b> [PATCH] mesa: silence MinGW 'may be unused uninitialized' warning in get.c</font> <div> </div> </div> <div class="BodyFragment"><font size="2"><span style="font-size:11pt;"> <div class="PlainText">The warning happens on line 2114 for the memcpy(data, p, size) call.<br> I'm not sure why that generates the warning but not the earlier use<br> of p in the code.<br> ---<br> src/mesa/main/get.c | 2 +-<br> 1 file changed, 1 insertion(+), 1 deletion(-)<br> <br> diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c<br> index 7f2d72a..5fee9a6 100644<br> --- a/src/mesa/main/get.c<br> +++ b/src/mesa/main/get.c<br> @@ -2051,7 +2051,7 @@ _mesa_GetUnsignedBytevEXT(GLenum pname, GLubyte *data)<br> const struct value_desc *d;<br> union value v;<br> int shift;<br> - void *p;<br> + void *p = NULL;<br> GLsizei size;<br> const char *func = "glGetUnsignedBytevEXT";<br> <br> -- <br> 2.7.4<br> <br> </div> </span></font></div> </body> </html>