<div dir="auto"><div>Lgtm, should probably get a rb from Intel though to make sure it doesn't break anything they're trying to do.</div><div dir="auto"><br></div><div dir="auto">Tested-by: Chuck Atkins <<a href="mailto:chuck.atkins@kitware.com">chuck.atkins@kitware.com</a>><br><div class="gmail_extra" dir="auto"><br><div class="gmail_quote">On Jan 29, 2018 07:09, "Emil Velikov" <<a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="elided-text">On 22 January 2018 at 17:52, Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com">emil.l.velikov@gmail.com</a>> wrote:<br>
> From: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>><br>
><br>
> With earlier rework the user and provider of the symbol are within the<br>
> same binary. Thus there's no point in exporting the function.<br>
><br>
> Spotted while reviewing patch from Chuck, that nearly added another<br>
> unneeded PUBLIC function.<br>
><br>
> Cc: Chuck Atkins <<a href="mailto:chuck.atkins@kitware.com">chuck.atkins@kitware.com</a>><br>
> Cc: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com">timothy.o.rowley@intel.com</a>><br>
> Fixes: f50aa21456d "(swr: build driver proper separate from rasterizer")<br>
> Signed-off-by: Emil Velikov <<a href="mailto:emil.velikov@collabora.com">emil.velikov@collabora.com</a>><br>
> ---<br>
> The comment might need updating as well, although I'm short on<br>
> suggestions.<br>
> ---<br>
>  src/gallium/drivers/swr/swr_<wbr>public.h   | 2 +-<br>
>  src/gallium/drivers/swr/swr_<wbr>screen.cpp | 1 -<br>
>  2 files changed, 1 insertion(+), 2 deletions(-)<br>
><br>
> diff --git a/src/gallium/drivers/swr/swr_<wbr>public.h b/src/gallium/drivers/swr/swr_<wbr>public.h<br>
> index 4b150705cd7..cb205479a91 100644<br>
> --- a/src/gallium/drivers/swr/swr_<wbr>public.h<br>
> +++ b/src/gallium/drivers/swr/swr_<wbr>public.h<br>
> @@ -36,7 +36,7 @@ extern "C" {<br>
>  struct pipe_screen *swr_create_screen(struct sw_winsys *winsys);<br>
><br>
>  // arch-specific dll entry point<br>
> -PUBLIC struct pipe_screen *swr_create_screen_internal(<wbr>struct sw_winsys *winsys);<br>
> +struct pipe_screen *swr_create_screen_internal(<wbr>struct sw_winsys *winsys);<br>
><br>
>  #ifdef _WIN32<br>
>  void swr_gdi_swap(struct pipe_screen *screen,<br>
> diff --git a/src/gallium/drivers/swr/swr_<wbr>screen.cpp b/src/gallium/drivers/swr/swr_<wbr>screen.cpp<br>
> index b67ac25ac89..10b7e891aca 100644<br>
> --- a/src/gallium/drivers/swr/swr_<wbr>screen.cpp<br>
> +++ b/src/gallium/drivers/swr/swr_<wbr>screen.cpp<br>
> @@ -1114,7 +1114,6 @@ swr_validate_env_options(<wbr>struct swr_screen *screen)<br>
>  }<br>
><br>
><br>
> -PUBLIC<br>
>  struct pipe_screen *<br>
>  swr_create_screen_internal(<wbr>struct sw_winsys *winsys)<br>
>  {<br>
> --<br>
</div>Humble ping?<br>
<br>
-Eiml<br>
</blockquote></div><br></div></div></div>