<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
</head>
<body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class="">
Yep, tested on our side, and looks good.
<div class=""><br class="">
</div>
<div class="">Reviewed-By: George Kyriazis <<a href="mailto:george.kyriazis@intel.com" class="">george.kyriazis@intel.com</a>></div>
<div class=""><br class="">
</div>
<div class=""><br class="">
<div class="">
<div>
<blockquote type="cite" class="">
<div class="">On Jan 29, 2018, at 9:42 AM, Chuck Atkins <<a href="mailto:chuck.atkins@kitware.com" class="">chuck.atkins@kitware.com</a>> wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="auto" class="">
<div class="">Lgtm, should probably get a rb from Intel though to make sure it doesn't break anything they're trying to do.</div>
<div dir="auto" class=""><br class="">
</div>
<div dir="auto" class="">Tested-by: Chuck Atkins <<a href="mailto:chuck.atkins@kitware.com" class="">chuck.atkins@kitware.com</a>><br class="">
<div class="gmail_extra" dir="auto"><br class="">
<div class="gmail_quote">On Jan 29, 2018 07:09, "Emil Velikov" <<a href="mailto:emil.l.velikov@gmail.com" class="">emil.l.velikov@gmail.com</a>> wrote:<br type="attribution" class="">
<blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="elided-text">On 22 January 2018 at 17:52, Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com" class="">emil.l.velikov@gmail.com</a>> wrote:<br class="">
> From: Emil Velikov <<a href="mailto:emil.velikov@collabora.com" class="">emil.velikov@collabora.com</a>><br class="">
><br class="">
> With earlier rework the user and provider of the symbol are within the<br class="">
> same binary. Thus there's no point in exporting the function.<br class="">
><br class="">
> Spotted while reviewing patch from Chuck, that nearly added another<br class="">
> unneeded PUBLIC function.<br class="">
><br class="">
> Cc: Chuck Atkins <<a href="mailto:chuck.atkins@kitware.com" class="">chuck.atkins@kitware.com</a>><br class="">
> Cc: Tim Rowley <<a href="mailto:timothy.o.rowley@intel.com" class="">timothy.o.rowley@intel.com</a>><br class="">
> Fixes: f50aa21456d "(swr: build driver proper separate from rasterizer")<br class="">
> Signed-off-by: Emil Velikov <<a href="mailto:emil.velikov@collabora.com" class="">emil.velikov@collabora.com</a>><br class="">
> ---<br class="">
> The comment might need updating as well, although I'm short on<br class="">
> suggestions.<br class="">
> ---<br class="">
> src/gallium/drivers/swr/swr_<wbr class="">public.h | 2 +-<br class="">
> src/gallium/drivers/swr/swr_<wbr class="">screen.cpp | 1 -<br class="">
> 2 files changed, 1 insertion(+), 2 deletions(-)<br class="">
><br class="">
> diff --git a/src/gallium/drivers/swr/swr_<wbr class="">public.h b/src/gallium/drivers/swr/swr_<wbr class="">public.h<br class="">
> index 4b150705cd7..cb205479a91 100644<br class="">
> --- a/src/gallium/drivers/swr/swr_<wbr class="">public.h<br class="">
> +++ b/src/gallium/drivers/swr/swr_<wbr class="">public.h<br class="">
> @@ -36,7 +36,7 @@ extern "C" {<br class="">
> struct pipe_screen *swr_create_screen(struct sw_winsys *winsys);<br class="">
><br class="">
> // arch-specific dll entry point<br class="">
> -PUBLIC struct pipe_screen *swr_create_screen_internal(<wbr class="">struct sw_winsys *winsys);<br class="">
> +struct pipe_screen *swr_create_screen_internal(<wbr class="">struct sw_winsys *winsys);<br class="">
><br class="">
> #ifdef _WIN32<br class="">
> void swr_gdi_swap(struct pipe_screen *screen,<br class="">
> diff --git a/src/gallium/drivers/swr/swr_<wbr class="">screen.cpp b/src/gallium/drivers/swr/swr_<wbr class="">screen.cpp<br class="">
> index b67ac25ac89..10b7e891aca 100644<br class="">
> --- a/src/gallium/drivers/swr/swr_<wbr class="">screen.cpp<br class="">
> +++ b/src/gallium/drivers/swr/swr_<wbr class="">screen.cpp<br class="">
> @@ -1114,7 +1114,6 @@ swr_validate_env_options(<wbr class="">struct swr_screen *screen)<br class="">
> }<br class="">
><br class="">
><br class="">
> -PUBLIC<br class="">
> struct pipe_screen *<br class="">
> swr_create_screen_internal(<wbr class="">struct sw_winsys *winsys)<br class="">
> {<br class="">
> --<br class="">
</div>
Humble ping?<br class="">
<br class="">
-Eiml<br class="">
</blockquote>
</div>
<br class="">
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</div>
</body>
</html>