<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, Feb 5, 2018 at 3:08 AM, Lionel Landwerlin <span dir="ltr"><<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Reviewed-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a><wbr>><br>
Fixes: abc62282b5c "anv: Add a per-device table of enabled extensions"<br>
<br>
We want it in 18.0 too I think.<br>
<br>
Thanks a lot!<span class=""><br>
<br>
On 05/02/18 09:46, Iago Toral Quiroga wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
The loop goes through the list of enabled extensions marking them as<br>
enabled in the list, but this relies on every other extension being<br>
initialized to false by default.<br>
<br>
This bug would make us, for example, advertise certain device extension<br>
entry points as available even when the corresponding extensions had<br>
not been enabled.<br>
---<br>
src/intel/vulkan/anv_device.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_device.<wbr>c b/src/intel/vulkan/anv_device.<wbr>c<br>
index 90e0fcfc46..7b151ebb5d 100644<br>
--- a/src/intel/vulkan/anv_device.<wbr>c<br>
+++ b/src/intel/vulkan/anv_device.<wbr>c<br>
@@ -1412,7 +1412,7 @@ VkResult anv_CreateDevice(<br>
assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_DEVICE_CREAT<wbr>E_INFO);<br>
- struct anv_device_extension_table enabled_extensions;<br>
+ struct anv_device_extension_table enabled_extensions = { };<br>
for (uint32_t i = 0; i < pCreateInfo->enabledExtensionC<wbr>ount; i++) {<br>
int idx;<br>
for (idx = 0; idx < ANV_DEVICE_EXTENSION_COUNT; idx++) {<br>
</blockquote>
<br>
<br></span>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div>