<div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Feb 6, 2018 at 4:22 PM, Nanley Chery <span dir="ltr"><<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Mon, Feb 05, 2018 at 04:07:19PM -0800, Anuj Phogat wrote:<br>
> I don't have a test case hitting this assert. But, it's nice to have<br>
> an assert checking the limit.<br>
><br>
> Signed-off-by: Anuj Phogat <<a href="mailto:anuj.phogat@gmail.com">anuj.phogat@gmail.com</a>><br>
> ---<br>
> src/intel/isl/isl_surface_<wbr>state.c | 2 ++<br>
> 1 file changed, 2 insertions(+)<br>
><br>
> diff --git a/src/intel/isl/isl_surface_<wbr>state.c b/src/intel/isl/isl_surface_<wbr>state.c<br>
> index bfb27fa4a4..afd4b80ddb 100644<br>
> --- a/src/intel/isl/isl_surface_<wbr>state.c<br>
> +++ b/src/intel/isl/isl_surface_<wbr>state.c<br>
> @@ -566,6 +566,8 @@ isl_genX(surf_fill_state_s)(<wbr>const struct isl_device *dev, void *state,<br>
> s.AuxiliarySurfaceBaseAddress = info->aux_address;<br>
> s.AuxiliarySurfacePitch = pitch_in_tiles - 1;<br>
><br>
> + assert(s.AuxiliarySurfacePitch <= 511);<br>
> +<br>
<br>
</span>genxml already performs this assertion for us, see:<br>
__gen_uint(values-><wbr>AuxiliarySurfacePitch, 3, 11)<br></blockquote><div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small"></div><div class="gmail_default" style="font-family:verdana,sans-serif;font-size:small">right. I'll drop this patch.</div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<span class=""><br>
<br>
> #if GEN_GEN >= 8<br>
> assert(GEN_GEN >= 9 || info->aux_usage != ISL_AUX_USAGE_CCS_E);<br>
> /* Auxiliary surfaces in ISL have compressed formats but the hardware<br>
> --<br>
> 2.13.6<br>
><br>
</span>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>