<div dir="ltr">Awesome!<div> </div><div>Reviewed-by: Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>></div></div><div class="gmail_extra"> <div class="gmail_quote">On Fri, Feb 9, 2018 at 1:54 PM, Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, This series removes the backlink to nir_to_llvm_context in ac_nir_context by moving some code to the ABI. We should also rename nir_to_llvm_context to radv_shader_context, move all RADV-specific code outside of ac and remove the link to ac_nir_context, but this series is a good start. Please review, Thanks! Samuel Pitoiset (18): ac/nir: remove unused nir_to_llvm_context:{defs,phis} ac: move tg_size to the ABI ac: move push_constants to the ABI ac: move view_index to the ABI ac: add load_sample_mask_in() to the ABI ac: add load_resource() to the ABI ac/nir: remove useless bitcast in load_tess_coord() ac: remove unused parameters in abi::load_tess_coord() ac/nir: drop nir_to_llvm_context from emit_f2f16() ac/nir: drop nir_to_llvm_context from visit_load_local_invocation_index() ac/nir: drop nir_to_llvm_context from cast_ptr() ac/nir: drop nir_to_llvm_context from visit_load_push_constant() ac/nir: drop nir_to_llvm_context from visit_vulkan_resource_reindex() ac/nir: drop nir_to_llvm_context from visit_var_atomic() ac/nir: drop nir_to_llvm_context from glsl_to_llvm_type() ac/nir: remove nir_to_llvm_context::builder ac/nir: remove nir_to_llvm_context::module ac/nir: remove backlink to nir_to_llvm_context src/amd/common/ac_nir_to_llvm.c | 407 +++++++++++++++---------------- src/amd/common/ac_shader_abi.h | 23 +- src/gallium/drivers/radeonsi/si_shader.c | 12 +- 3 files changed, 224 insertions(+), 218 deletions(-) -- 2.16.1 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>