<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Feb 14, 2018 at 9:42 AM, Ville Syrjälä <span dir="ltr"><<a href="mailto:ville.syrjala@linux.intel.com" target="_blank">ville.syrjala@linux.intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Wed, Feb 14, 2018 at 04:43:15PM +0000, Daniel Stone wrote:<br>
> On 14 February 2018 at 16:27, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
> > On Wed, Feb 14, 2018 at 3:39 AM, Daniel Stone <<a href="mailto:daniel@fooishbar.org">daniel@fooishbar.org</a>> wrote:<br>
> >> > On Tue, Feb 13, 2018 at 10:48 AM, Daniel Stone <<a href="mailto:daniel@fooishbar.org">daniel@fooishbar.org</a>> wrote:<br>
> >> >> For actual scanout, the kernel very specifically demands that if the<br>
> >> >> BO is X-tiled, then set_tiling be called with TILING_X. This applies<br>
> >> >> even if we explicitly allocate with MOD_X_TILED and pass that in via<br>
> >> >> drmModeAddFB2WithModifiers: there is an explicit check for<br>
> >> >> !!(bo_tiling == TILING_X) == !!(modifier == MOD_X_TILED).<br>
> >><br>
> >> You missed this bit. Suggested fixup: <a href="https://hastebin.com/xikopobiza" rel="noreferrer" target="_blank">https://hastebin.com/<wbr>xikopobiza</a><br>
> ><br>
> > I was really hoping I'd read wrong. I'm going with "that's a kernel bug".<br>
<br>
</span>Old kernels required TILING_X with MOD_X.</blockquote><div><br></div><div>How many kernels is that?<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I changed that at some<br>
point to allow TILING_NONE with any modifier, but otherwise we<br>
require the BO tiling to match the modifier. Ie. you still can't<br>
mix TILING_Y + MOD_X for example.<span class="HOEnZb"><font color="#888888"><br>
</font></span></blockquote></div><br></div><div class="gmail_extra">Right. That's perfectly reasonable. It should be either TILING_NONE or match.<br></div></div>