<div dir="ltr">Reviewed-by: Bas Nieuwenhuizen <<a href="mailto:bas@basnieuwenhuizen.nl">bas@basnieuwenhuizen.nl</a>></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 14, 2018 at 12:03 PM, Samuel Pitoiset <span dir="ltr"><<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Although meta shaders don't use any vertex buffers, there is no<br>
behaviour change but I think it's better to do this. Though,<br>
this saves two user SGPRs for push constants inlining or<br>
something else.<br>
<br>
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com">samuel.pitoiset@gmail.com</a>><br>
---<br>
src/amd/common/ac_shader_info.<wbr>c | 12 +++++++++++-<br>
1 file changed, 11 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/amd/common/ac_shader_<wbr>info.c b/src/amd/common/ac_shader_<wbr>info.c<br>
index 3b0887995d..f6cdd34703 100644<br>
--- a/src/amd/common/ac_shader_<wbr>info.c<br>
+++ b/src/amd/common/ac_shader_<wbr>info.c<br>
@@ -179,6 +179,16 @@ gather_info_block(const nir_shader *nir, const nir_block *block,<br>
}<br>
}<br>
<br>
+static void<br>
+gather_info_input_decl_vs(<wbr>const nir_shader *nir, const nir_variable *var,<br>
+ struct ac_shader_info *info)<br>
+{<br>
+ int idx = var->data.location;<br>
+<br>
+ if (idx >= VERT_ATTRIB_GENERIC0 && idx <= VERT_ATTRIB_GENERIC15)<br>
+ info->vs.has_vertex_buffers = true;<br>
+}<br>
+<br>
static void<br>
gather_info_input_decl_ps(<wbr>const nir_shader *nir, const nir_variable *var,<br>
struct ac_shader_info *info)<br>
@@ -197,7 +207,7 @@ gather_info_input_decl(const nir_shader *nir, const nir_variable *var,<br>
{<br>
switch (nir->info.stage) {<br>
case MESA_SHADER_VERTEX:<br>
- info->vs.has_vertex_buffers = true;<br>
+ gather_info_input_decl_vs(nir, var, info);<br>
break;<br>
case MESA_SHADER_FRAGMENT:<br>
gather_info_input_decl_ps(nir, var, info);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.16.1<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>