<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"><!-- P {margin-top:0;margin-bottom:0;} --></style>
</head>
<body dir="ltr">
<div id="divtagdefaultwrapper" style="font-size:12pt;color:#000000;font-family:Calibri,Helvetica,sans-serif;" dir="ltr">
<p style="margin-top:0;margin-bottom:0">Looks good.</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<p style="margin-top:0;margin-bottom:0">Reviewed-by: Neha Bhende<bhenden@vmware.com><br>
</p>
<p style="margin-top:0;margin-bottom:0"><br>
</p>
<div id="Signature">
<div id="divtagdefaultwrapper" style="font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255); font-family: Calibri,Arial,Helvetica,sans-serif,"EmojiFont","Apple Color Emoji","Segoe UI Emoji",NotoColorEmoji,"Segoe UI Symbol","Android Emoji",EmojiSymbols;">
<p>Regards,</p>
<p>Neha<br>
</p>
</div>
</div>
</div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Brian Paul <brianp@vmware.com><br>
<b>Sent:</b> Wednesday, February 14, 2018 1:53:52 PM<br>
<b>To:</b> mesa-dev@lists.freedesktop.org<br>
<b>Cc:</b> Charmaine Lee; Neha Bhende<br>
<b>Subject:</b> [PATCH] svga: s/unsigned/enum pipe_shader_type/</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">---<br>
src/gallium/drivers/svga/svga_tgsi.c | 3 ++-<br>
src/gallium/drivers/svga/svga_tgsi.h | 5 +++--<br>
src/gallium/drivers/svga/svga_tgsi_vgpu10.c | 2 +-<br>
3 files changed, 6 insertions(+), 4 deletions(-)<br>
<br>
diff --git a/src/gallium/drivers/svga/svga_tgsi.c b/src/gallium/drivers/svga/svga_tgsi.c<br>
index 0b2d8af..8819313 100644<br>
--- a/src/gallium/drivers/svga/svga_tgsi.c<br>
+++ b/src/gallium/drivers/svga/svga_tgsi.c<br>
@@ -168,7 +168,8 @@ svga_shader_emit_header(struct svga_shader_emitter *emit)<br>
struct svga_shader_variant *<br>
svga_tgsi_vgpu9_translate(struct svga_context *svga,<br>
const struct svga_shader *shader,<br>
- const struct svga_compile_key *key, unsigned unit)<br>
+ const struct svga_compile_key *key,<br>
+ enum pipe_shader_type unit)<br>
{<br>
struct svga_shader_variant *variant = NULL;<br>
struct svga_shader_emitter emit;<br>
diff --git a/src/gallium/drivers/svga/svga_tgsi.h b/src/gallium/drivers/svga/svga_tgsi.h<br>
index 2581135..e986011 100644<br>
--- a/src/gallium/drivers/svga/svga_tgsi.h<br>
+++ b/src/gallium/drivers/svga/svga_tgsi.h<br>
@@ -65,13 +65,14 @@ static inline void svga_generate_vdecl_semantics( unsigned idx,<br>
struct svga_shader_variant *<br>
svga_tgsi_vgpu9_translate(struct svga_context *svga,<br>
const struct svga_shader *shader,<br>
- const struct svga_compile_key *key, unsigned unit);<br>
+ const struct svga_compile_key *key,<br>
+ enum pipe_shader_type unit);<br>
<br>
struct svga_shader_variant *<br>
svga_tgsi_vgpu10_translate(struct svga_context *svga,<br>
const struct svga_shader *shader,<br>
const struct svga_compile_key *key,<br>
- unsigned unit);<br>
+ enum pipe_shader_type unit);<br>
<br>
boolean svga_shader_verify(const uint32_t *tokens, unsigned nr_tokens);<br>
<br>
diff --git a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c<br>
index 73aa78b..4d0834b 100644<br>
--- a/src/gallium/drivers/svga/svga_tgsi_vgpu10.c<br>
+++ b/src/gallium/drivers/svga/svga_tgsi_vgpu10.c<br>
@@ -6484,7 +6484,7 @@ struct svga_shader_variant *<br>
svga_tgsi_vgpu10_translate(struct svga_context *svga,<br>
const struct svga_shader *shader,<br>
const struct svga_compile_key *key,<br>
- unsigned unit)<br>
+ enum pipe_shader_type unit)<br>
{<br>
struct svga_shader_variant *variant = NULL;<br>
struct svga_shader_emitter_v10 *emit;<br>
-- <br>
2.7.4<br>
<br>
</div>
</span></font></div>
</body>
</html>