<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Fri, Feb 23, 2018 at 1:30 PM, Jose Maria Casanova Crespo <<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Range in 16-bit push constants load was being calculated wrongly using 4-bytes per element instead of 2-bytes as it should be. v2: Use glsl_get_bit_size instead of if statement (Jason Ekstrand) --- src/compiler/spirv/vtn_variables.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/compiler/spirv/vtn_variables.c b/src/compiler/spirv/vtn_variables.c index 78adab3ed2..e68551a336 100644 --- a/src/compiler/spirv/vtn_variables.c +++ b/src/compiler/spirv/vtn_variables.c @@ -683,12 +683,9 @@ vtn_type_block_size(struct vtn_builder *b, struct vtn_type *type) if (cols > 1) { vtn_assert(type->stride > 0); return type->stride * cols; - } else if (base_type == GLSL_TYPE_DOUBLE || - base_type == GLSL_TYPE_UINT64 || - base_type == GLSL_TYPE_INT64) { - return glsl_get_vector_elements(type->type) * 8; } else { - return glsl_get_vector_elements(type->type) * 4; + unsigned type_size = glsl_get_bit_size(type->type) / 8; + return glsl_get_vector_elements(type->type) * type_size; } } -- 2.16.1 </blockquote></div> </div>