<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p><br>
</p>
<br>
<div class="moz-cite-prefix">On 26/02/18 17:02, Jason Ekstrand
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAOFGe96eJcghvZZ1FrHaeX2G6xCmtzEaPinWzO6nhDQ9N9PMKw@mail.gmail.com">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">On Mon, Feb 26, 2018 at 12:58 AM,
Samuel Iglesias Gonsálvez <span dir="ltr"><<a
href="mailto:siglesias@igalia.com" target="_blank"
moz-do-not-send="true">siglesias@igalia.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">Signed-off-by:
Samuel Iglesias Gonsálvez <<a
href="mailto:siglesias@igalia.com"
moz-do-not-send="true">siglesias@igalia.com</a>><br>
---<br>
src/intel/vulkan/anv_formats.c | 6 +++++-<br>
1 file changed, 5 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/vulkan/anv_<wbr>formats.c
b/src/intel/vulkan/anv_<wbr>formats.c<br>
index 9c52ad5acbd..324797b7f10 100644<br>
--- a/src/intel/vulkan/anv_<wbr>formats.c<br>
+++ b/src/intel/vulkan/anv_<wbr>formats.c<br>
@@ -842,6 +842,10 @@ anv_get_image_format_<wbr>properties(<br>
*/<br>
}<br>
<br>
+ /* Pre-gen9 has a 2 GB limitation of the size in bytes
*/<br>
+ uint64_t maxResourceSize =<br>
+ devinfo->gen < 9 ? (uint64_t)( 1 << 31
) : UINT32_MAX;<br>
</blockquote>
<div><br>
</div>
<div>I think gen9's is actually much larger than UINT32_MAX,
isn't it?<br>
</div>
<div> </div>
</div>
</div>
</div>
</blockquote>
<br>
You are right. I am going to send a v2, including gen11+ too.<br>
<br>
Sam<br>
<br>
<blockquote type="cite"
cite="mid:CAOFGe96eJcghvZZ1FrHaeX2G6xCmtzEaPinWzO6nhDQ9N9PMKw@mail.gmail.com">
<div dir="ltr">
<div class="gmail_extra">
<div class="gmail_quote">
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex">
+<br>
*pImageFormatProperties = (VkImageFormatProperties) {<br>
.maxExtent = maxExtent,<br>
.maxMipLevels = maxMipLevels,<br>
@@ -851,7 +855,7 @@ anv_get_image_format_<wbr>properties(<br>
/* FINISHME: Accurately calculate<br>
* VkImageFormatProperties::<wbr>maxResourceSize.<br>
*/<br>
- .maxResourceSize = UINT32_MAX,<br>
+ .maxResourceSize = maxResourceSize,<br>
};<br>
<br>
if (pYcbcrImageFormatProperties) {<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.1<br>
<br>
</font></span></blockquote>
</div>
<br>
</div>
</div>
</blockquote>
<br>
</body>
</html>