<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Feb 21, 2018 at 1:45 PM, Rafael Antognolli <span dir="ltr"><<a href="mailto:rafael.antognolli@intel.com" target="_blank">rafael.antognolli@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Gen10, whenever the fast clear color changes, update it on the clear<br>
color entry buffer. This allow us to use it directly when emitting the<br>
surface state.<br>
<br>
Signed-off-by: Rafael Antognolli <<a href="mailto:rafael.antognolli@intel.com">rafael.antognolli@intel.com</a>><br>
---<br>
src/mesa/drivers/dri/i965/brw_<wbr>blorp.c | 26 ++++++++++++++++++++++++++<br>
1 file changed, 26 insertions(+)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c b/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
index 1d586e5ef38..25bfd118e7e 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>brw_blorp.c<br>
@@ -1142,6 +1142,27 @@ set_write_disables(const struct intel_renderbuffer *irb,<br>
return disables;<br>
}<br>
<br>
+static void<br>
+update_fast_clear_color(<wbr>struct brw_context *brw,<br>
+ struct blorp_surf *surf,<br>
+ const union isl_color_value clear_color)<br>
+{<br>
+ assert(surf);<br>
+ /* Clear values are stored at the same bo as the aux surface, right<br>
+ * after the surface.<br>
+ */<br>
+ uint32_t clear_offset = surf->aux_addr.offset + surf->aux_surf->size;<br>
+ for (int i = 0; i < brw->isl_dev.ss.clear_value_<wbr>size / 4; i++) {<br>
+ brw_store_data_imm32(brw, surf->aux_addr.buffer,<br>
+ clear_offset + i * 4, clear_color.u32[i]);<br>
+ }<br>
+<br>
+ surf->clear_color_addr = (struct blorp_address) {<br>
+ .buffer = surf->aux_addr.buffer,<br>
+ .offset = clear_offset,<br>
+ };<br></blockquote><div><br></div><div>I kind-of wonder if we don't want to just make core blorp do this. Something like<br><br></div><div>if (GEN_GEN >= 10 && params->dst.clear_color_addr.buffer &&<br></div><div> params->fast_clear_op == ISL_AUX_OP_FAST_CLEAR) {<br></div><div> /* Fill out the clear color */<br>}<br><br></div><div>I'm not actually sure that we do, but it's an idea. Other than that, this patch looks fine by me.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
+}<br>
+<br>
static void<br>
do_single_blorp_clear(struct brw_context *brw, struct gl_framebuffer *fb,<br>
struct gl_renderbuffer *rb, unsigned buf,<br>
@@ -1238,6 +1259,11 @@ do_single_blorp_clear(struct brw_context *brw, struct gl_framebuffer *fb,<br>
blorp_surf_for_miptree(brw, &surf, irb->mt, irb->mt->aux_usage, true,<br>
&level, irb->mt_layer, num_layers, isl_tmp);<br>
<br>
+ /* update clear color */<br>
+ const struct gen_device_info *devinfo = &brw->screen->devinfo;<br>
+ if (devinfo->gen >= 10 && !same_clear_color)<br>
+ update_fast_clear_color(brw, &surf, clear_color);<br>
+<br>
/* Ivybrigde PRM Vol 2, Part 1, "11.7 MCS Buffer for Render Target(s)":<br>
*<br>
* "Any transition from any value in {Clear, Render, Resolve} to a<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>