<div dir="ltr"><div><div><div><div>I've now read through the whole thing and sprinkled some comments. Over-all, I think it's looking pretty good.<br><br></div>There are a couple of bits of follow-on work that could be done:<br><br></div> 1) Now that we have indirect clear colors, we can allow non-default clear values for texturing and transfer ops in ANV. This is mostly a matter of making anv_blorp hand off the clear address in more cases and then enabling it in anv_layout_to_fast_clear_type<br><br></div> 2) Add a new I915_FORMAT_MOD_Y_TILED_CCS_CLEAR modifier and wire it up in Vulkan and GL. This will require adding a third fake plane for the CLEAR_COLOR state.<br><br></div>Neither of those need to be done as a prerequisite to landing this and you don't have to be the one to do them. However, I thought I should write it down somewhere.<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Feb 21, 2018 at 1:45 PM, Rafael Antognolli <span dir="ltr"><<a href="mailto:rafael.antognolli@intel.com" target="_blank">rafael.antognolli@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Rebase of this series after lots of aux surface changes on anv.<br>
<br>
Cc: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br>
Cc: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>><br>
Cc: Topi Pohjolainen <<a href="mailto:topi.pohjolainen@intel.com">topi.pohjolainen@intel.com</a>><br>
<br>
Rafael Antognolli (13):<br>
anv/image: Do not override lower bits of dword.<br>
genxml: Preserve fields that share dword space with addresses.<br>
intel/genxml: Use a single field for clear color address on gen10.<br>
intel/isl: Update size of clear color value.<br>
intel/genxml: Add Clear Color struct.<br>
intel/isl: Add support to emit clear value address.<br>
intel/blorp: Add suport for fast clear address.<br>
i965/miptree: Add space to store the clear value in the aux surface.<br>
i965/blorp: Update the fast clear color entry buffer.<br>
i965/surface_state: Emit the clear color address instead of value.<br>
i965/surface_state: Silence warning.<br>
anv: Emit the fast clear color address, instead of value.<br>
anv: Use clear address for HiZ fast clears too.<br>
<br>
src/intel/blorp/blorp_genX_<wbr>exec.h | 12 ++++--<br>
src/intel/genxml/gen10.xml | 15 +++++--<br>
src/intel/genxml/gen11.xml | 7 ++--<br>
src/intel/genxml/gen_pack_<wbr>header.py | 9 +++-<br>
src/intel/isl/isl.c | 29 +++++++++----<br>
src/intel/isl/isl.h | 14 +++++++<br>
src/intel/isl/isl_surface_<wbr>state.c | 18 ++++++--<br>
src/intel/vulkan/anv_device.c | 19 +++++++++<br>
src/intel/vulkan/anv_image.c | 53 ++++++++++++++++++------<br>
src/intel/vulkan/anv_private.h | 8 +++-<br>
src/intel/vulkan/genX_cmd_<wbr>buffer.c | 52 +++++++++++++++++++++--<br>
src/mesa/drivers/dri/i965/brw_<wbr>blorp.c | 26 ++++++++++++<br>
src/mesa/drivers/dri/i965/brw_<wbr>wm_surface_state.c | 18 +++++++-<br>
src/mesa/drivers/dri/i965/<wbr>intel_mipmap_tree.c | 10 +++++<br>
14 files changed, 245 insertions(+), 45 deletions(-)<br>
<span class="HOEnZb"><font color="#888888"><br>
--<br>
2.14.3<br>
<br>
</font></span></blockquote></div><br></div>