<div dir="ltr"><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div>I think they make sense as two separate patches. I've updated my patch title to say that it's only for match_value and I'll push both once Jenkins is done with them. </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Mar 1, 2018 at 9:06 AM, Jose Maria Casanova Crespo <<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">--- src/compiler/nir/nir_search.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/compiler/nir/nir_search.c b/src/compiler/nir/nir_search.c index c7c52ae320d..28b36b2b863 100644 --- a/src/compiler/nir/nir_search.c +++ b/src/compiler/nir/nir_search.c @@ -525,6 +525,9 @@ construct_value(const nir_search_value *value, case nir_type_float: load-><a href="http://def.name" rel="noreferrer" target="_blank">def.name</a> = ralloc_asprintf(load, "%f", c->data.d); switch (bitsize->dest_size) { + case 16: + load->value.u16[0] = _mesa_float_to_half(c->data.d); + break; case 32: load->value.f32[0] = c->data.d; break; @@ -539,6 +542,12 @@ construct_value(const nir_search_value *value, case nir_type_int: load-><a href="http://def.name" rel="noreferrer" target="_blank">def.name</a> = ralloc_asprintf(load, "%" PRIi64, c->data.i); switch (bitsize->dest_size) { + case 8: + load->value.i8[0] = c->data.i; + break; + case 16: + load->value.i16[0] = c->data.i; + break; case 32: load->value.i32[0] = c->data.i; break; @@ -553,6 +562,12 @@ construct_value(const nir_search_value *value, case nir_type_uint: load-><a href="http://def.name" rel="noreferrer" target="_blank">def.name</a> = ralloc_asprintf(load, "%" PRIu64, c->data.u); switch (bitsize->dest_size) { + case 8: + load->value.u8[0] = c->data.u; + break; + case 16: + load->value.u16[0] = c->data.u; + break; case 32: load->value.u32[0] = c->data.u; break; -- 2.14.3 </blockquote></div> </div>