<div dir="ltr"><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">Thanks a lot for the fixes.</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">There is small issue, if fails to build with meson with 'auto' if tizonia is installed but not bellagio because ENABLE_ST_OMX_BELLAGIO will remain defined.</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">Though it can be added afterward, and the series is:</div><div style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">Tested-by: Julien Isorce <<a href="mailto:julien.isorce@gmail.com" target="_blank">julien.isorce@gmail.com</a>></div><div class="gmail_extra"><br><div class="gmail_quote">On 7 March 2018 at 13:44, Eric Engestrom <span dir="ltr"><<a href="mailto:eric.engestrom@imgtec.com" target="_blank">eric.engestrom@imgtec.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span class="gmail-">On Tuesday, 2018-03-06 11:57:11 -0800, Dylan Baker wrote:<br>
> This fixes a couple of problems with the meson build support for the<br>
> recent omx tizonia integration, namely that it breaks a lot of<br>
> previously working meson configurations.<br>
<br>
</span>Thanks! Series is:<br>
Reviewed-by: Eric Engestrom <<a href="mailto:eric.engestrom@imgtec.com">eric.engestrom@imgtec.com</a>><br>
<div class="gmail-HOEnZb"><div class="gmail-h5"><br>
><br>
> The biggest change in here is the reintroduction of the 'auto' flag to<br>
> -Dgallium-omx. This allows configurations that lack tizonia, or that<br>
> otherwise can't build the omx tracker (i965, and gallium drivers other<br>
> than r600, radeon, or nouveau) to build without intervention.<br>
><br>
> This also fixes some style things, but those are pretty trivial.<br>
><br>
> Dylan Baker (5):<br>
> meson: combine state trackers and target if blocks<br>
> meson: fix tizonia compilation<br>
> meson: Re-add auto option for omx<br>
> meson: Use include directory variables instead of traversing<br>
> meson: Fix indent in omx meson.build<br>
><br>
> meson.build | 67 +++++++++++++++++++----------<br>
> meson_options.txt | 4 +-<br>
> src/egl/meson.build | 5 ++-<br>
> src/gallium/meson.build | 30 ++++---------<br>
> src/gallium/state_trackers/<wbr>dri/meson.build | 2 +<br>
> src/gallium/state_trackers/<wbr>omx/meson.build | 69 +++++++++++++++---------------<br>
> src/gbm/meson.build | 2 +-<br>
> 7 files changed, 95 insertions(+), 84 deletions(-)<br>
><br>
> --<br>
> 2.16.2<br>
><br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div></div>