<div dir="ltr">Ping.<div><br></div><div>Maybe it'd be better to just increase MAX_DYNAMIC_BUFFERS? I can't see any side effects of that other than increasing the size of radv_cmd_buffer?</div><div><br></div><div>Alex</div></div><div class="gmail_extra"><br><div class="gmail_quote">On 5 March 2018 at 09:59, Alex Smith <span dir="ltr"><<a href="mailto:asmith@feralinteractive.com" target="_blank">asmith@feralinteractive.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I just checked what Rise of the Tomb Raider is using. Maximum it hits for uniform buffers is 15, and 6 for storage buffers. The highest combined total is 15.<span class="HOEnZb"><font color="#888888"><div><br></div><div>Alex</div></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On 2 March 2018 at 20:11, Bas Nieuwenhuizen <span dir="ltr"><<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Alex,<br>
<br>
How many do you need of either type?<br>
<br>
- Bas<br>
<div><div class="m_580109633450549529h5"><br>
On Fri, Mar 2, 2018 at 4:28 PM, Alex Smith <<a href="mailto:asmith@feralinteractive.com" target="_blank">asmith@feralinteractive.com</a>> wrote:<br>
> These were set to MAX_DYNAMIC_BUFFERS / 2, which is too restrictive<br>
> since an app may have it's total usage of both uniform and storage<br>
> within MAX_DYNAMIC_BUFFERS, but exceed the limit for one of the types.<br>
><br>
> Recently the validation layers have started raising errors for when<br>
> these limits are exceeded, so these are firing for something that<br>
> actually works just fine.<br>
><br>
> Set the limit for both to MAX_DYNAMIC_BUFFERS. Not ideal because it<br>
> now allows the total across both to exceed the real limit, but we have<br>
> no way to express that limit properly.<br>
><br>
> Cc: <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop<wbr>.org</a>><br>
> Signed-off-by: Alex Smith <<a href="mailto:asmith@feralinteractive.com" target="_blank">asmith@feralinteractive.com</a>><br>
> ---<br>
>  src/amd/vulkan/radv_device.c | 4 ++--<br>
>  1 file changed, 2 insertions(+), 2 deletions(-)<br>
><br>
> diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c<br>
> index 36d7a406bf..1e81ddb891 100644<br>
> --- a/src/amd/vulkan/radv_device.c<br>
> +++ b/src/amd/vulkan/radv_device.c<br>
> @@ -717,9 +717,9 @@ void radv_GetPhysicalDeviceProperti<wbr>es(<br>
>                 .maxPerStageResources                     = max_descriptor_set_size,<br>
>                 .maxDescriptorSetSamplers                 = max_descriptor_set_size,<br>
>                 .maxDescriptorSetUniformBuffe<wbr>rs           = max_descriptor_set_size,<br>
> -               .maxDescriptorSetUniformBuffe<wbr>rsDynamic    = MAX_DYNAMIC_BUFFERS / 2,<br>
> +               .maxDescriptorSetUniformBuffe<wbr>rsDynamic    = MAX_DYNAMIC_BUFFERS,<br>
>                 .maxDescriptorSetStorageBuffe<wbr>rs           = max_descriptor_set_size,<br>
> -               .maxDescriptorSetStorageBuffe<wbr>rsDynamic    = MAX_DYNAMIC_BUFFERS / 2,<br>
> +               .maxDescriptorSetStorageBuffe<wbr>rsDynamic    = MAX_DYNAMIC_BUFFERS,<br>
>                 .<wbr>maxDescriptorSetSampledImages            = max_descriptor_set_size,<br>
>                 .<wbr>maxDescriptorSetStorageImages            = max_descriptor_set_size,<br>
>                 .maxDescriptorSetInputAttachm<wbr>ents         = max_descriptor_set_size,<br>
> --<br>
> 2.14.3<br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div>
</div></div></blockquote></div><br></div>