<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Mar 27, 2018 at 4:11 AM, Samuel Pitoiset <span dir="ltr"><<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class=""><br>
<br>
On 03/27/2018 02:39 AM, Marek Olšák wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Marek Olšák <<a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a>><br>
<br>
---<br>
src/gallium/drivers/radeonsi/s<wbr>i_shader.c | 5 +++++<br>
1 file changed, 5 insertions(+)<br>
<br>
diff --git a/src/gallium/drivers/radeonsi<wbr>/si_shader.c b/src/gallium/drivers/radeonsi<wbr>/si_shader.c<br>
index 8ae742c93f6..00ebbb9b0f2 100644<br>
--- a/src/gallium/drivers/radeonsi<wbr>/si_shader.c<br>
+++ b/src/gallium/drivers/radeonsi<wbr>/si_shader.c<br>
@@ -7964,20 +7964,25 @@ static bool si_shader_select_ps_parts(stru<wbr>ct si_screen *sscreen,<br>
if (!shader->key.part.ps.epilog.p<wbr>oly_line_smoothing &&<br>
!shader->selector->info.reads_<wbr>samplemask)<br>
shader->config.spi_ps_input_en<wbr>a &= C_0286CC_SAMPLE_COVERAGE_ENA;<br>
return true;<br>
}<br>
void si_multiwave_lds_size_workarou<wbr>nd(struct si_screen *sscreen,<br>
unsigned *lds_size)<br>
{<br>
+ /* If tessellation is all offchip and on-chip GS isn't used, this<br>
+ * workaround is not needed.<br>
+ */<br>
+ return;<br>
</blockquote>
<br></span>
Is this expected to always return here? Why you don't remove the entire workaround then?</blockquote><div><br></div><div>It documents why the workaround isn't needed.<br><br></div><div>Marek<br></div></div><br></div></div>