<div dir="ltr"><div>I finally got around to reading through this series again. Everything which I didn't comment on is </div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Mar 8, 2018 at 8:48 AM, Rafael Antognolli <<a href="mailto:rafael.antognolli@intel.com" target="_blank">rafael.antognolli@intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">New revision of this series. Major differences are: - I tried to incorporate most of the review feedback. - While adding some code in i965 to update the clear color state buffer, I seemd to avoid some bugs by actually doing it in blorp. However, anv already updates the same buffer, so in order to avoid having both places doing that, I tried to centralize that code in blorp. - Now blorp updates the clear color whenever we are doing a fast clear and have the clear_color_addr field set with a valid buffer. Cc: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> Cc: Jordan Justen <<a href="mailto:jordan.l.justen@intel.com">jordan.l.justen@intel.com</a>> Rafael Antognolli (18): anv/image: Do not override lower bits of dword. genxml: Preserve fields that share dword space with addresses. intel/genxml: Use a single field for clear color address on gen10. intel/genxml: Add Clear Color struct. intel/isl: Add support to emit clear value address. intel/blorp: Add support for fast clear address. intel/blorp: Only copy clear color when doing a resolve. intel/blorp: Update clear color state buffer during fast clears. i965/miptree: Add space to store the clear value in the aux surface. i965/miptree: Add new BO for clear color. i965/blorp: Add aux_buf variable to simplify code. i965/blorp: Update the fast clear color address. i965/surface_state: Emit the clear color address instead of value. anv: Add a helper to extract clear color from the attachment. anv: Emit the fast clear color address, instead of value. anv: Use clear address for HiZ fast clears too. anv: Make blorp update the clear color. intel: Remove use_clear_address flag from isl_surf_fill_state_info. src/intel/blorp/blorp_genX_exec.h | 75 ++++++++++++++++++++--- src/intel/genxml/gen10.xml | 15 +++-- src/intel/genxml/gen11.xml | 17 ++++-- src/intel/genxml/gen_pack_header.py | 9 ++- src/intel/isl/isl.c | 23 ++++--- src/intel/isl/isl.h | 14 +++++ src/intel/isl/isl_surface_state.c | 5 +- src/intel/vulkan/anv_blorp.c | 69 +++++++++++++++------ src/intel/vulkan/anv_device.c | 19 ++++++ src/intel/vulkan/anv_image.c | 47 +++++++++++---- src/intel/vulkan/anv_private.h | 38 +++++++++++- src/intel/vulkan/genX_cmd_buffer.c | 76 +++++++++++++----------- src/mesa/drivers/dri/i965/brw_blorp.c | 26 ++++---- src/mesa/drivers/dri/i965/brw_clear.c | 22 +++++++ src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 26 +++++++- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 34 +++++++++++ src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 16 +++++ 17 files changed, 423 insertions(+), 108 deletions(-) -- 2.14.3 </blockquote></div> </div>