<div dir="ltr"><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>><br><br></div>Marek<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Sat, Mar 31, 2018 at 7:32 PM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Without this the return value will never get set to -1. This<br>
was first added in 49866c8f3457 and copied in 2b396eeed983.<br>
<br>
Fixes: 2b396eeed983 "gallium/pb_cache: add a copy of cache bufmgr independent of pb_manager"<br>
<br>
Cc: Marek Olšák <<a href="mailto:maraeo@gmail.com">maraeo@gmail.com</a>><br>
Cc: Dave Airlie <<a href="mailto:airlied@gmail.com">airlied@gmail.com</a>><br>
Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=102342" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=102342</a><br>
---<br>
src/gallium/auxiliary/<wbr>pipebuffer/pb_cache.c | 2 +-<br>
1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/gallium/auxiliary/<wbr>pipebuffer/pb_cache.c b/src/gallium/auxiliary/<wbr>pipebuffer/pb_cache.c<br>
index 0aaedbfae4c..2b9ad498045 100644<br>
--- a/src/gallium/auxiliary/<wbr>pipebuffer/pb_cache.c<br>
+++ b/src/gallium/auxiliary/<wbr>pipebuffer/pb_cache.c<br>
@@ -169,7 +169,7 @@ pb_cache_reclaim_buffer(struct pb_cache *mgr, pb_size size,<br>
cur_entry = LIST_ENTRY(struct pb_cache_entry, cur, head);<br>
<br>
if (!entry && (ret = pb_cache_is_buffer_compat(cur_<wbr>entry, size,<br>
- alignment, usage) > 0))<br>
+ alignment, usage)) > 0)<br>
entry = cur_entry;<br>
else if (os_time_timeout(cur_entry-><wbr>start, cur_entry->end, now))<br>
destroy_buffer_locked(cur_<wbr>entry);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.3<br>
<br>
</font></span></blockquote></div><br></div>