<div dir="ltr"><div class="gmail_extra">.<div class="gmail_quote">On Tue, Apr 3, 2018 at 6:21 AM, Karol Herbst <span dir="ltr"><<a href="mailto:kherbst@redhat.com" target="_blank">kherbst@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">If the bindless image is passed through a struct we ended up getting the<br>
glsl_type of the struct, not the image.<br>
<br>
variable_referenced points to the declaration of the struct, so it won't work<br>
for bindless images. So just drop it.<br>
<br>
Signed-off-by: Karol Herbst <<a href="mailto:kherbst@redhat.com">kherbst@redhat.com</a>><br>
---<br>
 src/compiler/glsl/glsl_to_nir.<wbr>cpp | 2 +-<br>
 1 file changed, 1 insertion(+), 1 deletion(-)<br>
<br>
diff --git a/src/compiler/glsl/glsl_to_<wbr>nir.cpp b/src/compiler/glsl/glsl_to_<wbr>nir.cpp<br>
index 8e2d96a2361..1fc0cac4736 100644<br>
--- a/src/compiler/glsl/glsl_to_<wbr>nir.cpp<br>
+++ b/src/compiler/glsl/glsl_to_<wbr>nir.cpp<br>
@@ -893,7 +893,7 @@ nir_visitor::visit(ir_call *ir)<br>
          exec_node *param = ir->actual_parameters.get_<wbr>head();<br>
          ir_dereference *image = (ir_dereference *)param;<br>
          const glsl_type *type =<br>
-            image->variable_referenced()-><wbr>type->without_array();<br>
+            image->type->without_array();<br></blockquote><div><br></div><div>Do we still need without_array()?  If that really is the dereferenced type, it should be an image type already.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
          instr->variables[0] = evaluate_deref(&instr->instr, image);<br>
          param = param->get_next();<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>