<div dir="ltr"><div>2-7 are<br><br></div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Mar 30, 2018 at 11:12 AM, Nanley Chery <span dir="ltr"><<a href="mailto:nanleychery@gmail.com" target="_blank">nanleychery@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The paths which sample with the clear color are now using a getter which<br>
performs the sRGB decode needed to enable this fast clear.<br>
<br>
This path can be exercised by fast-clearing a texture, then performing<br>
an operation which requires sRGB decoding. Test coverage for this<br>
feature is provided with the following tests:<br>
<br>
* Shader texture calls:<br>
- spec@ext_texture_srgb@tex-srgb<br>
<br>
* Shader texelfetch calls:<br>
- spec@arb_framebuffer_srgb@fbo-<wbr>fast-clear<br>
- spec@arb_framebuffer_srgb@<wbr>msaa-fast-clear<br>
<br>
* Blending:<br>
- spec@arb_framebuffer_srgb@arb_<wbr>framebuffer_srgb-fast-clear-<wbr>blend<br>
<br>
* Blitting:<br>
- spec@arb_framebuffer_srgb@blit texture srgb msaa enabled clear<br>
---<br>
src/mesa/drivers/dri/i965/brw_<wbr>meta_util.c | 11 -----------<br>
1 file changed, 11 deletions(-)<br>
<br>
diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_meta_util.c b/src/mesa/drivers/dri/i965/<wbr>brw_meta_util.c<br>
index b31181521c7..d292f5a8e24 100644<br>
--- a/src/mesa/drivers/dri/i965/<wbr>brw_meta_util.c<br>
+++ b/src/mesa/drivers/dri/i965/<wbr>brw_meta_util.c<br>
@@ -293,18 +293,7 @@ brw_is_color_fast_clear_<wbr>compatible(struct brw_context *brw,<br>
brw->mesa_to_isl_render_<wbr>format[mt->format])<br>
return false;<br>
<br>
- const bool srgb_rb = _mesa_get_srgb_format_linear(<wbr>mt->format) != mt->format;<br>
- /* Gen10 doesn't automatically decode the clear color of sRGB buffers. Since<br>
- * we currently don't perform this decode in software, avoid a fast-clear<br>
- * altogether. TODO: Do this in software.<br>
- */<br>
const mesa_format format = _mesa_get_render_format(ctx, mt->format);<br>
- if (devinfo->gen >= 10 && srgb_rb) {<br>
- perf_debug("sRGB fast clear not enabled for (%s)",<br>
- _mesa_get_format_name(format))<wbr>;<br>
- return false;<br>
- }<br>
-<br>
if (_mesa_is_format_integer_<wbr>color(format)) {<br>
if (devinfo->gen >= 8) {<br>
perf_debug("Integer fast clear not enabled for (%s)",<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.16.2<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>