<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Wed, Apr 4, 2018 at 3:33 AM, Timothy Arceri <span dir="ltr"><<a href="mailto:tarceri@itsqueeze.com" target="_blank">tarceri@itsqueeze.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 04/04/18 20:20, Karol Herbst wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> On Wed, Apr 4, 2018 at 2:23 AM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net" target="_blank">jason@jlekstrand.net</a>> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> I have a very strong feeling that this isn't the only place where<br> reading/writing IMAGE and SAMPLER variables is going to cause NIR heartburn.<br> For example, we have special cases in nir_validate for SUBROUTINE variables<br> and we probably need IMAGE and SAMPLER support everywhere we have SUBROUTINE<br> plus some (since you can write to them now as well).<br> <br> </blockquote> <br> yeah. I was just making piglit happy here. I guess I will try to run<br> it with some games using bindless_textures and fix all the crashes I<br> encounter there at least. More piglit tests might be useful as well.<br> Sadly I don't see any bindless_textures tests in the CTS :(<br> </blockquote> <br></span> I don't think games really use the spec to its full extent either. I had Dawn of War 3 working without issue with just the uniform support implemented on radeonsi.<br></blockquote><div><br></div><div>Sounds like someone gets to write some more piglit tests. :-)<br><br></div><div>--Jason<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <div class="HOEnZb"><div class="h5"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> On Tue, Apr 3, 2018 at 6:21 AM, Karol Herbst <<a href="mailto:kherbst@redhat.com" target="_blank">kherbst@redhat.com</a>> wrote:<br> <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"> <br> Signed-off-by: Karol Herbst <<a href="mailto:kherbst@redhat.com" target="_blank">kherbst@redhat.com</a>><br> ---<br> src/compiler/nir/nir_split_var<wbr>_copies.c | 4 ++++<br> 1 file changed, 4 insertions(+)<br> <br> diff --git a/src/compiler/nir/nir_split_v<wbr>ar_copies.c<br> b/src/compiler/nir/nir_split_v<wbr>ar_copies.c<br> index bc3ceedbdb8..231a89add4d 100644<br> --- a/src/compiler/nir/nir_split_v<wbr>ar_copies.c<br> +++ b/src/compiler/nir/nir_split_v<wbr>ar_copies.c<br> @@ -241,6 +241,10 @@ split_var_copies_block(nir_blo<wbr>ck *block, struct<br> split_var_copies_state *state)<br> ralloc_steal(state->dead_ctx, instr);<br> }<br> break;<br> + /* for bindless those are uint64 */<br> + case GLSL_TYPE_IMAGE:<br> + case GLSL_TYPE_SAMPLER:<br> + assert(src_head->var-><a href="http://data.bi">data.bi</a><wbr>ndless);<br> case GLSL_TYPE_INT:<br> case GLSL_TYPE_UINT:<br> case GLSL_TYPE_INT16:<br> --<br> 2.14.3<br> <br> ______________________________<wbr>_________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> </blockquote> <br> <br> </blockquote> ______________________________<wbr>_________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> <br> </blockquote> </div></div></blockquote></div><br></div></div>