<div dir="ltr">Hello, Mark.<div>I've done: Cc, <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Tested-by and <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Reviewed-by also added.</span></span></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 4, 2018 at 8:16 AM, Mark Janes <span dir="ltr"><<a href="mailto:mark.a.janes@intel.com" target="_blank">mark.a.janes@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">This patch passes Intel's CI suites.<br>
It needs a CC for stable in the commit message.<br>
<br>
Tested-by: Mark Janes <<a href="mailto:mark.a.janes@intel.com">mark.a.janes@intel.com</a>><br>
<div><div class="h5"><br>
Sergii Romantsov <<a href="mailto:sergii.romantsov@gmail.com">sergii.romantsov@gmail.com</a>> writes:<br>
<br>
> Gen8+ use 48-bit address relocations so need to extend the sign<br>
> to 64-bit return value. Without it we have higher bits zeroed<br>
> and missing the negavive values.<br>
> Haswell and older use 32-bit deltas so are unaffected by this issue.<br>
><br>
> v2:<br>
>   used int32_t fucntion parameter instead of explicit type conversion.<br>
><br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=101408" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=101408</a><br>
> Signed-off-by: Sergii Romantsov <<a href="mailto:sergii.romantsov@globallogic.com">sergii.romantsov@globallogic.<wbr>com</a>><br>
> Tested-by: Andriy Khulap <<a href="mailto:andriy.khulap@globallogic.com">andriy.khulap@globallogic.com</a><wbr>><br>
> ---<br>
>  src/mesa/drivers/dri/i965/<wbr>intel_batchbuffer.c | 2 +-<br>
>  1 file changed, 1 insertion(+), 1 deletion(-)<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_batchbuffer.c b/src/mesa/drivers/dri/i965/<wbr>intel_batchbuffer.c<br>
> index ebc02ff..7286140 100644<br>
> --- a/src/mesa/drivers/dri/i965/<wbr>intel_batchbuffer.c<br>
> +++ b/src/mesa/drivers/dri/i965/<wbr>intel_batchbuffer.c<br>
> @@ -1079,7 +1079,7 @@ brw_batch_references(struct intel_batchbuffer *batch, struct brw_bo *bo)<br>
>  static uint64_t<br>
>  emit_reloc(struct intel_batchbuffer *batch,<br>
>             struct brw_reloc_list *rlist, uint32_t offset,<br>
> -           struct brw_bo *target, uint32_t target_offset,<br>
> +           struct brw_bo *target, int32_t target_offset,<br>
>             unsigned int reloc_flags)<br>
>  {<br>
>     assert(target != NULL);<br>
> --<br>
> 2.7.4<br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div>