<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Thu, Apr 5, 2018 at 8:45 AM, James Xiong <span dir="ltr"><<a href="mailto:james.xiong@intel.com" target="_blank">james.xiong@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Thu, 5 Apr 2018 08:24:27 -0700<br>
Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
<br>
> Does this fix a bug? If so, what?<br>
</span>Jason, yes. I am sorry for the confusion, please see my earlier reply<br>
to Tapani.<br></blockquote><div><br></div><div>If it fixes a bug then the commit message should include a description of the bug fixed. If the bug is a regression, it should have a "Fixes: SHA1" tag indicating where the regression originated and if it is a bug that has been around for a very long time, it should have a "Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.org</a>" tag. If the bug is filed in bugzilla, it should have a "Bugzilla: <link>" tag.<br><br></div><div>--Jason<br><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5">><br>
> On April 4, 2018 16:57:21 James Xiong <<a href="mailto:james.xiong@intel.com">james.xiong@intel.com</a>> wrote:<br>
><br>
> > From: "Xiong, James" <<a href="mailto:james.xiong@intel.com">james.xiong@intel.com</a>><br>
> ><br>
> > When creating a image from a texture, initialize the image's<br>
> > planar_format with the texture's.<br>
> ><br>
> > Signed-off-by: Xiong, James <<a href="mailto:james.xiong@intel.com">james.xiong@intel.com</a>><br>
> > ---<br>
> > src/mesa/drivers/dri/i965/<wbr>intel_screen.c | 1 +<br>
> > 1 file changed, 1 insertion(+)<br>
> ><br>
> > diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_screen.c<br>
> > b/src/mesa/drivers/dri/i965/<wbr>intel_screen.c<br>
> > index dcb98da..7df8bc4 100644<br>
> > --- a/src/mesa/drivers/dri/i965/<wbr>intel_screen.c<br>
> > +++ b/src/mesa/drivers/dri/i965/<wbr>intel_screen.c<br>
> > @@ -578,6 +578,7 @@ intel_create_image_from_<wbr>texture(__DRIcontext<br>
> > *context, int target,<br>
> > intel_setup_image_from_mipmap_<wbr>tree(brw, image, iobj->mt, level,<br>
> > zoffset); image->dri_format =<br>
> > driGLFormatToImageFormat(<wbr>image->format); image->has_depthstencil =<br>
> > iobj->mt->stencil_mt? true : false;<br>
> > + image->planar_format = iobj->planar_format;<br>
> > if (image->dri_format == MESA_FORMAT_NONE) {<br>
> > *error = __DRI_IMAGE_ERROR_BAD_<wbr>PARAMETER;<br>
> > free(image);<br>
> > --<br>
> > 2.7.4<br>
> ><br>
> > ______________________________<wbr>_________________<br>
> > mesa-dev mailing list<br>
> > <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> > <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
><br>
><br>
><br>
<br>
</div></div></blockquote></div><br></div></div>