<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Apr 10, 2018 at 12:52 PM, Caio Marcelo de Oliveira Filho <span dir="ltr"><<a href="mailto:caio.oliveira@intel.com" target="_blank">caio.oliveira@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">The return value was needed to make use of the old nir_foreach_block<br>
helper, but not needed anymore with the macro version.<br></blockquote><div><br></div><div>Nice bit of archaeology there. :-)<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c | 4 +---<br>
1 file changed, 1 insertion(+), 3 deletions(-)<br>
<br>
diff --git a/src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c b/src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c<br>
index 0cc65143e7..fe30c69756 100644<br>
--- a/src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c<br>
+++ b/src/compiler/nir/nir_lower_<wbr>vars_to_ssa.c<br>
@@ -407,7 +407,7 @@ register_copy_instr(nir_<wbr>intrinsic_instr *copy_instr,<br>
}<br>
<br>
/* Registers all variable uses in the given block. */<br>
-static bool<br>
+static void<br>
register_variable_uses_block(<wbr>nir_block *block,<br>
struct lower_variables_state *state)<br>
{<br>
@@ -434,8 +434,6 @@ register_variable_uses_block(<wbr>nir_block *block,<br>
continue;<br>
}<br>
}<br>
-<br>
- return true;<br></blockquote><div><br></div><div>We can probably go even further and either inline this function or else (and I think I would prefer this one) move the nir_foreach_block into it and drop the _block suffix from the name. In any case, this is better<br><br></div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
}<br>
<br>
/* Walks over all of the copy instructions to or from the given deref_node<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.17.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>