<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 10, 2018 at 7:37 AM, Daniel Schürmann <span dir="ltr"><<a href="mailto:daniel.schuermann@campus.tu-berlin.de" target="_blank">daniel.schuermann@campus.tu-berlin.de</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
src/compiler/spirv/spirv_to_<wbr>nir.c | 2 ++<br>
src/compiler/spirv/vtn_<wbr>subgroup.c | 2 ++<br>
2 files changed, 4 insertions(+)<br>
<br>
diff --git a/src/compiler/spirv/spirv_to_<wbr>nir.c b/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
index 78c1e9ff59..28274311c2 100644<br>
--- a/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
+++ b/src/compiler/spirv/spirv_to_<wbr>nir.c<br>
@@ -3361,10 +3361,12 @@ vtn_handle_preamble_<wbr>instruction(struct vtn_builder *b, SpvOp opcode,<br>
<br>
case SpvCapabilityGroupNonUniformQu<wbr>ad:<br>
spv_check_supported(subgroup_<wbr>quad, cap);<br>
+ break;<br>
<br>
case SpvCapabilityGroupNonUniformAr<wbr>ithmetic:<br>
case SpvCapabilityGroupNonUniformCl<wbr>ustered:<br>
spv_check_supported(subgroup_<wbr>arithmetic, cap);<br>
+ break;<br>
<br>
case SpvCapabilityVariablePointersS<wbr>torageBuffer:<br>
case SpvCapabilityVariablePointers:<br>
diff --git a/src/compiler/spirv/vtn_<wbr>subgroup.c b/src/compiler/spirv/vtn_<wbr>subgroup.c<br>
index bd3143962b..ecec3aa62d 100644<br>
--- a/src/compiler/spirv/vtn_<wbr>subgroup.c<br>
+++ b/src/compiler/spirv/vtn_<wbr>subgroup.c<br>
@@ -277,6 +277,8 @@ vtn_handle_subgroup(struct vtn_builder *b, SpvOp opcode,<br>
case 2:<br>
op = nir_intrinsic_quad_swap_<wbr>diagonal;<br>
break;<br>
+ default:<br>
+ vtn_fail("Invalid constant value in OpGroupNonUniformQuadSwap");<br>
}<br>
vtn_build_subgroup_instr(b, op, val->ssa, vtn_ssa_value(b, w[4]),<br>
NULL, 0, 0);<br>
<span class="HOEnZb"><font color="#888888">--<br>
2.14.1<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>