<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, Apr 10, 2018 at 7:46 PM, Bas Nieuwenhuizen <span dir="ltr"><<a href="mailto:bas@basnieuwenhuizen.nl" target="_blank">bas@basnieuwenhuizen.nl</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">What is the addrlib assertion we are hitting?<br></blockquote><div><br></div><div>128bpp formats can't set "display = true" even though the tiling is always _D for 128bpp.<br><br></div><div>Marek<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div class="h5"><br>
On Tue, Apr 10, 2018 at 11:44 AM, Michel Dänzer <<a href="mailto:michel@daenzer.net">michel@daenzer.net</a>> wrote:<br>
> On 2018-04-06 07:12 PM, Marek Olšák wrote:<br>
>> From: Marek Olšák <<a href="mailto:marek.olsak@amd.com">marek.olsak@amd.com</a>><br>
>><br>
>> This enables the tile swizzle for some cases of the displayable micro mode,<br>
>> and it also fixes an addrlib assertion failure on Vega.<br>
><br>
> [...]<br>
><br>
>> diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c<br>
>> index dd3189c67d0..ef6f1072abd 100644<br>
>> --- a/src/amd/vulkan/radv_image.c<br>
>> +++ b/src/amd/vulkan/radv_image.c<br>
>> @@ -919,20 +919,21 @@ radv_image_create(VkDevice _device,<br>
>> if (!image)<br>
>> return vk_error(VK_ERROR_OUT_OF_HOST_<wbr>MEMORY);<br>
>><br>
>> image->type = pCreateInfo->imageType;<br>
>> image->info.width = pCreateInfo->extent.width;<br>
>> image->info.height = pCreateInfo->extent.height;<br>
>> image->info.depth = pCreateInfo->extent.depth;<br>
>> image->info.samples = pCreateInfo->samples;<br>
>> image->info.array_size = pCreateInfo->arrayLayers;<br>
>> image->info.levels = pCreateInfo->mipLevels;<br>
>> + image->info.num_channels = 4; /* TODO: set this correctly */<br>
><br>
> Maybe a radv developer can suggest something here? Anyway,<br>
><br>
> Reviewed-by: Michel Dänzer <<a href="mailto:michel.daenzer@amd.com">michel.daenzer@amd.com</a>><br>
><br>
><br>
> --<br>
> Earthling Michel Dänzer | <a href="http://www.amd.com" rel="noreferrer" target="_blank">http://www.amd.com</a><br>
> Libre software enthusiast | Mesa and X developer<br>
</div></div>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div></div>