<div dir="ltr">I don't really get what this patch is doing. Why not just use image->n_planes? </div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Apr 12, 2018 at 11:37 AM, Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com" target="_blank">lionel.g.landwerlin@intel.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">We're not counting correctly with depth & stencil images. Signed-off-by: Lionel Landwerlin <<a href="mailto:lionel.g.landwerlin@intel.com">lionel.g.landwerlin@intel.com</a>> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=105994" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=105994</a> --- src/intel/vulkan/anv_private.h | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/intel/vulkan/anv_private.h b/src/intel/vulkan/anv_private.h index 53115ae470f..a4297511bbb 100644 --- a/src/intel/vulkan/anv_private.h +++ b/src/intel/vulkan/anv_private.h @@ -2356,6 +2356,10 @@ anv_image_aspect_get_planes(VkImageAspectFlags aspect_mask) if (aspect_mask & VK_IMAGE_ASPECT_PLANE_2_BIT) planes++; + if (aspect_mask & VK_IMAGE_ASPECT_DEPTH_BIT && + aspect_mask & VK_IMAGE_ASPECT_STENCIL_BIT) + planes++; + return planes; } -- 2.17.0 _______________________________________________ mesa-dev mailing list <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/mesa-dev</a> </blockquote></div> </div>