<html> <head> <base href="https://bugs.freedesktop.org/"> </head> <body> <div> <a class="bz_bug_link bz_status_NEW " title="NEW - radv: si_scissor_from_viewport returns incorrect result when using half-pixel viewport offset" href="https://bugs.freedesktop.org/show_bug.cgi?id=106074#c1">Comment # 1</a> on <a class="bz_bug_link bz_status_NEW " title="NEW - radv: si_scissor_from_viewport returns incorrect result when using half-pixel viewport offset" href="https://bugs.freedesktop.org/show_bug.cgi?id=106074">bug 106074</a> from <a class="email" href="mailto:philip.rebohle@tu-dortmund.de" title="Philip Rebohle <philip.rebohle@tu-dortmund.de>"> Philip Rebohle</a> <pre>Created <a href="attachment.cgi?id=138867" name="attach_138867" title="Proposed patch">attachment 138867</a> <a href="attachment.cgi?id=138867&action=edit" title="Proposed patch">[details]</a> <a href='page.cgi?id=splinter.html&bug=106074&attachment=138867'>[review]</a> Proposed patch The attached patch fixes the issue in FF XIV. I'm not sure if that is entirely correct, but the use of the integer version of 'abs' in the following code looks incorrect given that 'scale[i]' can be non-integer even if the viewport size is integer. rect.offset.x = translate[0] - abs(scale[0]); rect.offset.y = translate[1] - abs(scale[1]); rect.extent.width = ceilf(translate[0] + abs(scale[0])) - rect.offset.x; rect.extent.height = ceilf(translate[1] + abs(scale[1])) - rect.offset.y; Also it seems that my assumption that the size should be (1,1) was incorrect, it should indeed be (2,2). This is in line with what RadeonSI returns.</pre> </div> <hr> You are receiving this mail because: <ul> <li>You are the QA Contact for the bug.</li> <li>You are the assignee for the bug.</li> </ul> </body> </html>