<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 16, 2018 at 6:45 AM, Erico Nunes <span dir="ltr"><<a href="mailto:nunes.erico@gmail.com" target="_blank">nunes.erico@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On Sun, Apr 15, 2018 at 2:30 AM, Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> wrote:<br>
> On April 14, 2018 12:43:35 Connor Abbott <<a href="mailto:cwabbott0@gmail.com">cwabbott0@gmail.com</a>> wrote:<br>
</span><span class="">> I think that it's probably impractical to use this path, and we should<br>
> probably delete it. There are just too many optimizations, e.g. in<br>
> nir_opt_algebraic and lowering passes that assume you have ints. I<br>
> think a better plan would be to silently convert ints to floats in the<br>
> lima driver, and maybe inhibit any optimizations that use bit<br>
> twiddling tricks if real int support isn't indicated.<br>
><br>
> I'm not sure. For quite a while prog_to_nir used these comparison<br>
> operations so we know they more it less work. For all I know, maybe it<br>
> still does (I didn't actually check). The only thing we need to worry about<br>
> in terms of correctness is any optimizations in nir_opt_algebraic which<br>
> consume only floats but produce integers. Also, all drivers need to handle<br>
> imov simply because it's easy.<br>
><br>
> That being said, we've done a lot of work to optimize the integer supporting<br>
> paths so you may actually get better code if you can figure out a good way<br>
> to lower the integers away.<br>
<br>
</span>I'm not really using ints in my sample program, just floats. But still<br>
I'm getting nir_op_slt and nir_op_sge for the float comparison<br>
operations.<br>
Should I be getting nir_op_flt and nir_op_fge instead even with<br>
.native_integers disabled in glsl_to_nir?<br>
</blockquote></div><br></div><div class="gmail_extra">Nope. That's kind of what the native_integers option is for. I'm just saying that it isn't incredibly well tested so be ware.<br></div></div>