<div dir="ltr">Marek, thanks for suggestion.<div>But I've tested your <a href="https://patchwork.freedesktop.org/patch/217304/">patch</a> and, unfortunately, it doesn't fix the <a href="https://bugs.freedesktop.org/show_bug.cgi?id=105438">https://bugs.freedesktop.org/show_bug.cgi?id=105438</a></div><div><br></div><div>Regards, Andriy.</div></div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 17, 2018 at 8:33 PM, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Actually, if you just apply my patch, it should fix glsl_to_nir too.<span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888">Marek</font></span><div><div class="h5"><br><div><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 17, 2018 at 1:31 PM, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Skipping an instruction is incorrect.<br></div><div><br>I recommend something like this: <a href="https://patchwork.freedesktop.org/patch/217304/" target="_blank">https://patchwork.freedesktop.<wbr>org/patch/217304/</a><span class="m_-3596416859127836246HOEnZb"><font color="#888888"><br><br></font></span></div><span class="m_-3596416859127836246HOEnZb"><font color="#888888"><div>Marek<br></div><div><br></div><br></font></span></div><div class="m_-3596416859127836246HOEnZb"><div class="m_-3596416859127836246h5"><div class="gmail_extra"><br><div class="gmail_quote">On Tue, Apr 3, 2018 at 8:32 AM, Andriy Khulap <span dir="ltr"><<a href="mailto:andriy.khulap@gmail.com" target="_blank">andriy.khulap@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=105438" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/s<wbr>how_bug.cgi?id=105438</a><br>
Signed-off-by: Andriy Khulap <<a href="mailto:andriy.khulap@globallogic.com" target="_blank">andriy.khulap@globallogic.com</a><wbr>><br>
Signed-off-by: Vadym Shovkoplias <<a href="mailto:vadym.shovkoplias@globallogic.com" target="_blank">vadym.shovkoplias@globallogic<wbr>.com</a>><br>
---<br>
 src/compiler/glsl/glsl_to_nir<wbr>.cpp | 3 +++<br>
 1 file changed, 3 insertions(+)<br>
<br>
diff --git a/src/compiler/glsl/glsl_to_ni<wbr>r.cpp b/src/compiler/glsl/glsl_to_ni<wbr>r.cpp<br>
index dbb58d82e8..1a0cd822a0 100644<br>
--- a/src/compiler/glsl/glsl_to_ni<wbr>r.cpp<br>
+++ b/src/compiler/glsl/glsl_to_ni<wbr>r.cpp<br>
@@ -1952,6 +1952,9 @@ nir_visitor::visit(ir_expressi<wbr>on *ir)<br>
    case ir_quadop_vector:<br>
       result = nir_vec(&b, srcs, ir->type->vector_elements);<br>
       break;<br>
+   case ir_binop_vector_extract:<br>
+      /* Prevent the unreachable trap */<br>
+      break;<br>
<br>
    default:<br>
       unreachable("not reached");<br>
<span class="m_-3596416859127836246m_-3418300868008848108HOEnZb"><font color="#888888">-- <br>
2.16.2<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div></div></div></div></div>
</blockquote></div><br></div>