<div dir="ltr"><div>Well, it fixes some piglits, but I don't remember which ones.<br><br></div>Marek<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, Apr 18, 2018 at 5:31 AM, Nicolai Hähnle <span dir="ltr"><<a href="mailto:nhaehnle@gmail.com" target="_blank">nhaehnle@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">On 16.04.2018 23:02, Marek Olšák wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
From: Marek Olšák <<a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a>><br>
<br>
Cc: 18.0 <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop<wbr>.org</a>><br>
</blockquote>
<br></span>
Would be nice to have an indication of what this fixes. Apart from that it looks reasonable.<br>
<br>
Reviewed-by: Nicolai Hähnle <<a href="mailto:nicolai.haehnle@amd.com" target="_blank">nicolai.haehnle@amd.com</a>><div><div class="h5"><br>
<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
---<br>
src/mesa/state_tracker/st_glsl<wbr>_to_tgsi.cpp | 5 +++++<br>
1 file changed, 5 insertions(+)<br>
<br>
diff --git a/src/mesa/state_tracker/st_gl<wbr>sl_to_tgsi.cpp b/src/mesa/state_tracker/st_gl<wbr>sl_to_tgsi.cpp<br>
index 01a58d7d2c6..b321112cf88 100644<br>
--- a/src/mesa/state_tracker/st_gl<wbr>sl_to_tgsi.cpp<br>
+++ b/src/mesa/state_tracker/st_gl<wbr>sl_to_tgsi.cpp<br>
@@ -7117,20 +7117,25 @@ st_link_shader(struct gl_context *ctx, struct gl_shader_program *prog)<br>
/* Repeat it until it stops making changes. */<br>
bool progress;<br>
do {<br>
progress = do_common_optimization(ir, true, true, options,<br>
ctx->Const.NativeIntegers);<br>
progress |= lower_if_to_cond_assign((gl_sh<wbr>ader_stage)i, ir,<br>
options->MaxIfDepth, if_threshold);<br>
} while (progress);<br>
}<br>
+ /* Do this again to lower ir_binop_vector_extract introduced<br>
+ * by optimization passes.<br>
+ */<br>
+ do_vec_index_to_cond_assign(ir<wbr>);<br>
+<br>
validate_ir_tree(ir);<br>
}<br>
build_program_resource_list(c<wbr>tx, prog);<br>
if (use_nir)<br>
return st_link_nir(ctx, prog);<br>
for (unsigned i = 0; i < MESA_SHADER_STAGES; i++) {<br>
struct gl_linked_shader *shader = prog->_LinkedShaders[i];<br>
<br>
</blockquote>
<br>
<br>
-- <br></div></div>
Lerne, wie die Welt wirklich ist,<br>
Aber vergiss niemals, wie sie sein sollte.<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div>