<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 23, 2018 at 1:36 PM, Francisco Jerez <span dir="ltr"><<a href="mailto:currojerez@riseup.net" target="_blank">currojerez@riseup.net</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> writes:<br>
<br>
> They are send messages and this makes size_written() and mlen agree.<br>
<br>
</span>You mean size_read()?  And commit message should probably read "Return<br>
mlen * 32 for size_read for INTERPOLATE_AT_*" to reflect what the commit<br>
is doing.<span class=""><br></span></blockquote><div><br></div><div>Yes.  That was a typo.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">
> For both of these opcodes, the payload is just a dummy so mlen == 1 and<br>
> this should decrease register pressure a bit.<br>
><br>
<br>
</span>Reviewed-by: Francisco Jerez <<a href="mailto:currojerez@riseup.net">currojerez@riseup.net</a>><br><div class="HOEnZb"><div class="h5"></div></div></blockquote><div><br></div><div>Thanks!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="HOEnZb"><div class="h5">
> Cc: Francisco Jerez <<a href="mailto:currojerez@riseup.net">currojerez@riseup.net</a>><br>
> Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.<wbr>org</a><br>
> ---<br>
>  src/intel/compiler/brw_fs.cpp | 2 ++<br>
>  1 file changed, 2 insertions(+)<br>
><br>
> diff --git a/src/intel/compiler/brw_fs.<wbr>cpp b/src/intel/compiler/brw_fs.<wbr>cpp<br>
> index 40896db..8156507 100644<br>
> --- a/src/intel/compiler/brw_fs.<wbr>cpp<br>
> +++ b/src/intel/compiler/brw_fs.<wbr>cpp<br>
> @@ -842,6 +842,8 @@ fs_inst::size_read(int arg) const<br>
>     case SHADER_OPCODE_TYPED_ATOMIC:<br>
>     case SHADER_OPCODE_TYPED_SURFACE_<wbr>READ:<br>
>     case SHADER_OPCODE_TYPED_SURFACE_<wbr>WRITE:<br>
> +   case FS_OPCODE_INTERPOLATE_AT_<wbr>SAMPLE:<br>
> +   case FS_OPCODE_INTERPOLATE_AT_<wbr>SHARED_OFFSET:<br>
>     case FS_OPCODE_INTERPOLATE_AT_PER_<wbr>SLOT_OFFSET:<br>
>     case SHADER_OPCODE_BYTE_SCATTERED_<wbr>WRITE:<br>
>     case SHADER_OPCODE_BYTE_SCATTERED_<wbr>READ:<br>
> -- <br>
> 2.5.0.400.gff86faf<br>
</div></div></blockquote></div><br></div></div>