<html> <head> <meta http-equiv="Content-Type" content="text/html; charset=us-ascii"> </head> <body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space;" class=""> I agree on the commit message wording. <div class=""><br class=""> </div> <div class="">Sorry about missing passes.h in the original check-in.</div> <div class=""><br class=""> </div> <div class="">Reviewed-by: George Kyriazis <<a href="mailto:george.kyriazis@intel.com" class="">george.kyriazis@intel.com</a>></div> <div class=""><br class=""> <div> <blockquote type="cite" class=""> <div class="">On Apr 20, 2018, at 10:00 PM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" class="">kenneth@whitecape.org</a>> wrote:</div> <br class="Apple-interchange-newline"> <div class=""> <div class="">On Friday, April 20, 2018 7:19:50 PM PDT Dylan Baker wrote:<br class=""> <blockquote type="cite" class="">Signed-off-by: Dylan Baker <<a href="mailto:dylan.c.baker@intel.com" class="">dylan.c.baker@intel.com</a>><br class=""> ---<br class=""> src/gallium/drivers/swr/Makefile.sources | 1 +<br class=""> 1 file changed, 1 insertion(+)<br class=""> <br class=""> diff --git a/src/gallium/drivers/swr/Makefile.sources b/src/gallium/drivers/swr/Makefile.sources<br class=""> index dd815dcb581..a06d1d7b929 100644<br class=""> --- a/src/gallium/drivers/swr/Makefile.sources<br class=""> +++ b/src/gallium/drivers/swr/Makefile.sources<br class=""> @@ -155,6 +155,7 @@ JITTER_CXX_SOURCES := \<br class=""> <span class="Apple-tab-span" style="white-space:pre"></span>rasterizer/jitter/streamout_jit.cpp \<br class=""> <span class="Apple-tab-span" style="white-space:pre"></span>rasterizer/jitter/streamout_jit.h \<br class=""> <span class="Apple-tab-span" style="white-space:pre"></span>rasterizer/jitter/shader_lib/DebugOutput.cpp \<br class=""> +<span class="Apple-tab-span" style="white-space:pre"> </span>rasterizer/jitter/functionpasses/passes.h \<br class=""> <span class="Apple-tab-span" style="white-space:pre"></span>rasterizer/jitter/functionpasses/lower_x86.cpp<br class=""> <br class=""> MEMORY_CXX_SOURCES := \<br class=""> <br class=""> </blockquote> <br class=""> I would add the following to the commit message:<br class=""> <br class=""> This was introduced in commit 8f848ada8a42d9aaa8136afa1bafe32281a0fb48 <br class=""> but not added to the sources list, which is necessary for it to be<br class=""> included in release tarballs.<br class=""> <br class=""> Fixes: 8f848ada8a42d9aaa8136afa1bafe32281a0fb48 (swr/rast: Start refactoring of builder/packetizer.)<br class=""> Reviewed-by: Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" class="">kenneth@whitecape.org</a>><br class=""> _______________________________________________<br class=""> mesa-dev mailing list<br class=""> <a href="mailto:mesa-dev@lists.freedesktop.org" class="">mesa-dev@lists.freedesktop.org</a><br class=""> https://lists.freedesktop.org/mailman/listinfo/mesa-dev<br class=""> </div> </div> </blockquote> </div> <br class=""> </div> </body> </html>