<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, Apr 23, 2018 at 10:00 AM, Dylan Baker <span dir="ltr"><<a href="mailto:dylan@pnwbakers.com" target="_blank">dylan@pnwbakers.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">You have a typo in the commit message "srink" -> "shrink"<br></blockquote><div><br></div><div>Thanks! Fixed.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Quoting Jason Ekstrand (2018-04-20 22:15:00)<br>
<div><div class="h5">> Previously, we only tried to ensure that we didn't shrink either end<br>
> below what was already handed out.  However, due to the way we handle<br>
> relocations with block pools, we can't shrink the back end at all.  It's<br>
> probably best to not shrink in either direction.<br>
> <br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=105374" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=105374</a><br>
> Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=106147" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/<wbr>show_bug.cgi?id=106147</a><br>
> Cc: <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.<wbr>org</a><br>
> ---<br>
>  src/intel/vulkan/anv_<wbr>allocator.c | 8 ++++----<br>
>  1 file changed, 4 insertions(+), 4 deletions(-)<br>
> <br>
> diff --git a/src/intel/vulkan/anv_<wbr>allocator.c b/src/intel/vulkan/anv_<wbr>allocator.c<br>
> index f884ac3..642e161 100644<br>
> --- a/src/intel/vulkan/anv_<wbr>allocator.c<br>
> +++ b/src/intel/vulkan/anv_<wbr>allocator.c<br>
> @@ -508,12 +508,12 @@ anv_block_pool_grow(struct anv_block_pool *pool, struct anv_block_state *state)<br>
>        assert(center_bo_offset >= back_used);<br>
>  <br>
>        /* Make sure we don't shrink the back end of the pool */<br>
> -      if (center_bo_offset < pool->back_state.end)<br>
> -         center_bo_offset = pool->back_state.end;<br>
> +      if (center_bo_offset < back_required)<br>
> +         center_bo_offset = back_required;<br>
>  <br>
>        /* Make sure that we don't shrink the front end of the pool */<br>
> -      if (size - center_bo_offset < pool->state.end)<br>
> -         center_bo_offset = size - pool->state.end;<br>
> +      if (size - center_bo_offset < front_required)<br>
> +         center_bo_offset = size - front_required;<br>
>     }<br>
>  <br>
>     assert(center_bo_offset % PAGE_SIZE == 0);<br>
> -- <br>
> 2.5.0.400.gff86faf<br>
> <br>
</div></div>> ______________________________<wbr>_________________<br>
> mesa-stable mailing list<br>
> <a href="mailto:mesa-stable@lists.freedesktop.org">mesa-stable@lists.freedesktop.<wbr>org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-stable" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-stable</a><br>
</blockquote></div><br></div></div>