<div dir="ltr">Correct, my mesa tree did not include those changes in include/GL/internal/dri_interface.h that landed in [1].<div>I'll rebase and come back here. Thanks!<br><div><br></div><div>[1] <a href="https://cgit.freedesktop.org/mesa/mesa/commit/include/GL/internal/dri_interface.h?id=f3878aa622c30f8b4e110464157fcdebc910603c">https://cgit.freedesktop.org/mesa/mesa/commit/include/GL/internal/dri_interface.h?id=f3878aa622c30f8b4e110464157fcdebc910603c</a></div></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 27 April 2018 at 16:38, Ilia Mirkin <span dir="ltr"><<a href="mailto:imirkin@alum.mit.edu" target="_blank">imirkin@alum.mit.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Looks like your patch is against a fairly old tree. In the current<br>
one, the following dri image formats exist:<br>
<br>
#define __DRI_IMAGE_FORMAT_XBGR2101010 0x1010<br>
#define __DRI_IMAGE_FORMAT_ABGR2101010 0x1011<br>
#define __DRI_IMAGE_FORMAT_SABGR8 0x1012<br>
<br>
I piped the XB30/AB30 stuff through to st/mesa -- I suspect I didn't<br>
touch the intel driver though, so those are probably still valid. Do<br>
check though.<br>
<br>
-ilia<br>
<div><div class="h5"><br>
<br>
On Fri, Apr 27, 2018 at 4:16 PM, Miguel Casas <<a href="mailto:mcasas@chromium.org">mcasas@chromium.org</a>> wrote:<br>
> This patch adds support for XBGR2101010 (a.k.a. XB30) to i965.<br>
> ToT supports XR30/AR30; XB30 is needed to support GL_RGB10_*<br>
> texture internal formats with the correct channel order.<br>
><br>
> BUG=<a href="https://crbug.com/776093" rel="noreferrer" target="_blank">https://crbug.com/776093</a><br>
> TEST=Compile and deploy mesa+this patch, then playback<br>
> a VP9 Profile 2 video with sw decoder using <a href="http://crrev.com/c/897894" rel="noreferrer" target="_blank">crrev.com/c/897894</a>.<br>
><br>
> Change-Id: Ib6b4e435d526670777e0aebcf03bf<wbr>19432ae5c9d<br>
> ---<br>
> include/GL/internal/dri_<wbr>interface.h | 1 +<br>
> src/mesa/drivers/dri/i965/brw_<wbr>surface_formats.c | 1 +<br>
> src/mesa/drivers/dri/i965/<wbr>intel_screen.c | 3 +++<br>
> 3 files changed, 5 insertions(+)<br>
><br>
> diff --git a/include/GL/internal/dri_<wbr>interface.h b/include/GL/internal/dri_<wbr>interface.h<br>
> index 34a5c9fb01..d4bcf4f80d 100644<br>
> --- a/include/GL/internal/dri_<wbr>interface.h<br>
> +++ b/include/GL/internal/dri_<wbr>interface.h<br>
> @@ -1227,6 +1227,7 @@ struct __DRIdri2ExtensionRec {<br>
> #define __DRI_IMAGE_FORMAT_R16 0x100d<br>
> #define __DRI_IMAGE_FORMAT_GR1616 0x100e<br>
> #define __DRI_IMAGE_FORMAT_YUYV 0x100f<br>
> +#define __DRI_IMAGE_FORMAT_XBGR2101010 0x1010<br>
><br>
> #define __DRI_IMAGE_USE_SHARE 0x0001<br>
> #define __DRI_IMAGE_USE_SCANOUT 0x0002<br>
> diff --git a/src/mesa/drivers/dri/i965/<wbr>brw_surface_formats.c b/src/mesa/drivers/dri/i965/<wbr>brw_surface_formats.c<br>
> index 879cb42453..c1d0b80df8 100644<br>
> --- a/src/mesa/drivers/dri/i965/<wbr>brw_surface_formats.c<br>
> +++ b/src/mesa/drivers/dri/i965/<wbr>brw_surface_formats.c<br>
> @@ -187,6 +187,7 @@ brw_isl_format_for_mesa_<wbr>format(mesa_format mesa_format)<br>
> [MESA_FORMAT_R11G11B10_FLOAT] = ISL_FORMAT_R11G11B10_FLOAT,<br>
><br>
> [MESA_FORMAT_R10G10B10A2_<wbr>UNORM] = ISL_FORMAT_R10G10B10A2_UNORM,<br>
> + [MESA_FORMAT_R10G10B10X2_<wbr>UNORM] = ISL_FORMAT_R10G10B10A2_UNORM,<br>
> [MESA_FORMAT_B10G10R10A2_UINT] = ISL_FORMAT_B10G10R10A2_UINT,<br>
> [MESA_FORMAT_R10G10B10A2_UINT] = ISL_FORMAT_R10G10B10A2_UINT,<br>
><br>
> diff --git a/src/mesa/drivers/dri/i965/<wbr>intel_screen.c b/src/mesa/drivers/dri/i965/<wbr>intel_screen.c<br>
> index a4e34e9f2c..8d548d92f3 100644<br>
> --- a/src/mesa/drivers/dri/i965/<wbr>intel_screen.c<br>
> +++ b/src/mesa/drivers/dri/i965/<wbr>intel_screen.c<br>
> @@ -186,6 +186,9 @@ static const struct intel_image_format intel_image_formats[] = {<br>
> { __DRI_IMAGE_FOURCC_<wbr>XRGB2101010, __DRI_IMAGE_COMPONENTS_RGB, 1,<br>
> { { 0, 0, 0, __DRI_IMAGE_FORMAT_<wbr>XRGB2101010, 4 } } },<br>
><br>
> + { __DRI_IMAGE_FOURCC_<wbr>XBGR2101010, __DRI_IMAGE_COMPONENTS_RGB, 1,<br>
> + { { 0, 0, 0, __DRI_IMAGE_FORMAT_<wbr>XBGR2101010, 4 } } },<br>
> +<br>
> { __DRI_IMAGE_FOURCC_ARGB8888, __DRI_IMAGE_COMPONENTS_RGBA, 1,<br>
> { { 0, 0, 0, __DRI_IMAGE_FORMAT_ARGB8888, 4 } } },<br>
><br>
> --<br>
> 2.13.5<br>
><br>
</div></div>> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</blockquote></div><br></div>