<div dir="ltr"><div><span class="gmail-im" style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">Hello, Michel</div><div><span class="gmail-im" style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial"> </div><span class="gmail-im" style="color:rgb(80,0,80);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial">On 2018-04-10 09:44 AM, Sergii Romantsov wrote: > Commit 3160cb86aa92 adds optimization with flag 'reallocate'. > Processing of flag causes buffers freeing while pointer > is still hold in caller stack and than again used to be freed. > > Fixes: 3160cb86aa92 "egl/x11: Re-allocate buffers if format is suboptimal" > > v2: > used flag 'busy' instead of introducing new one. > > Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=105906" rel="noreferrer" target="_blank" style="color:rgb(17,85,204)">https://bugs.freedesktop.org/show_bug.cgi?id=105906</a> > Signed-off-by: Sergii Romantsov <<a href="mailto:sergii.romantsov@globallogic.com" style="color:rgb(17,85,204)">sergii.romantsov@globallogic.com</a>> > Tested-by: Andriy Khulap <<a href="mailto:andriy.khulap@globallogic.com" style="color:rgb(17,85,204)">andriy.khulap@globallogic.com</a>> > --- > src/loader/loader_dri3_helper.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c > index fe17df1..a934db1 100644 > --- a/src/loader/loader_dri3_helper.c > +++ b/src/loader/loader_dri3_helper.c > @@ -1688,6 +1688,7 @@ dri3_get_buffer(__DRIdrawable *driDrawable, > (buffer_type == loader_dri3_buffer_front && draw->have_fake_front)) > && buffer) { > > + buffer->busy = true; > /* Fill the new buffer with data from an old buffer */ > dri3_fence_await(draw->conn, draw, buffer); > if (!loader_dri3_blit_image(draw, <div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">Hello, Michel,</div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">I've updated patch according to your remarks: <a href="https://lists.freedesktop.org/archives/mesa-dev/2018-April/193331.html">https://lists.freedesktop.org/archives/mesa-dev/2018-April/193331.html</a></div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"> </div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">And about question</div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;font-size:12.8px;float:none;display:inline">This seems a bit of a hack. Will this always be cleared again, in <span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;font-size:12.8px;float:none;display:inline">particular if it's the fake front buffer? </blockquote>There are seems no needs in clearing due the next step is unconditional freeing of that buffer by call 'dri3_free_render_buffer(draw, buffer)'.</div><div><span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:12.8px;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline"> </div></div><div class="gmail_extra"> <div class="gmail_quote">On Thu, Apr 26, 2018 at 7:43 PM, Michel Dänzer <<a href="mailto:michel@daenzer.net" target="_blank">michel@daenzer.net</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 2018-04-10 09:44 AM, Sergii Romantsov wrote: > Commit 3160cb86aa92 adds optimization with flag 'reallocate'. > Processing of flag causes buffers freeing while pointer > is still hold in caller stack and than again used to be freed. > > Fixes: 3160cb86aa92 "egl/x11: Re-allocate buffers if format is suboptimal" > > v2: > used flag 'busy' instead of introducing new one. > > Bugzilla: <a href="https://bugs.freedesktop.org/show_bug.cgi?id=105906" rel="noreferrer" target="_blank">https://bugs.freedesktop.org/show_bug.cgi?id=105906</a> > Signed-off-by: Sergii Romantsov <<a href="mailto:sergii.romantsov@globallogic.com">sergii.romantsov@globallogic.com</a>> > Tested-by: Andriy Khulap <<a href="mailto:andriy.khulap@globallogic.com">andriy.khulap@globallogic.com</a>> > --- > src/loader/loader_dri3_helper.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/src/loader/loader_dri3_helper.c b/src/loader/loader_dri3_helper.c > index fe17df1..a934db1 100644 > --- a/src/loader/loader_dri3_helper.c > +++ b/src/loader/loader_dri3_helper.c > @@ -1688,6 +1688,7 @@ dri3_get_buffer(__DRIdrawable *driDrawable, > (buffer_type == loader_dri3_buffer_front && draw->have_fake_front)) > && buffer) { > > + buffer->busy = true; > /* Fill the new buffer with data from an old buffer */ > dri3_fence_await(draw->conn, draw, buffer); > if (!loader_dri3_blit_image(draw, This seems a bit of a hack. Will this always be cleared again, in particular if it's the fake front buffer? > @@ -1731,6 +1732,7 @@ dri3_get_buffer(__DRIdrawable *driDrawable, > draw->buffers[buf_id] = buffer; > } > dri3_fence_await(draw->conn, draw, buffer); > + buffer = draw->buffers[buf_id]; This should be something like if (buffer_type == loader_dri3_buffer_back) { buf_id = dri3_find_back(draw); if (buf_id < 0) return NULL; } buffer = draw->buffers[buf_id]; to get the now-current back buffer. > @@ -1744,7 +1746,8 @@ dri3_get_buffer(__DRIdrawable *driDrawable, > if (buffer_type == loader_dri3_buffer_back && > draw->cur_blit_source != -1 && > draw->buffers[draw->cur_blit_source] && > - buffer != draw->buffers[draw->cur_blit_source]) { > + buffer != draw->buffers[draw->cur_blit_source] && > + buffer != NULL) { > > struct loader_dri3_buffer *source = draw->buffers[draw->cur_blit_source]; > > With the above, this NULL guard isn't needed. -- Earthling Michel Dänzer | <a href="http://www.amd.com" rel="noreferrer" target="_blank">http://www.amd.com</a> Libre software enthusiast | Mesa and X developer </blockquote></div> </div>