<div dir="ltr"><div>Ignore that. Nicolai's point is correct.<br><br></div>Marek<br><div><div><div class="gmail_extra"><br><div class="gmail_quote">On Fri, Apr 27, 2018 at 1:51 AM, Marek Olšák <span dir="ltr"><<a href="mailto:maraeo@gmail.com" target="_blank">maraeo@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div>Reviewed-by: Marek Olšák <<a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a>><span class="HOEnZb"><font color="#888888"><br><br></font></span></div><span class="HOEnZb"><font color="#888888">Marek<br></font></span></div><div class="HOEnZb"><div class="h5"><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 26, 2018 at 6:17 AM, Samuel Pitoiset <span dir="ltr"><<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Otherwise we hit an assertion in ac_build_image_opcode()<br>
for ac_image_load_mip.<br>
<br>
Fixes: 24fb3e6aa16 ("ac/nir: use ac_build_image_opcode for image intrinsics")<br>
Cc: 18.1 <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop<wbr>.org</a>><br>
Signed-off-by: Samuel Pitoiset <<a href="mailto:samuel.pitoiset@gmail.com" target="_blank">samuel.pitoiset@gmail.com</a>><br>
---<br>
 src/amd/common/ac_nir_to_<wbr>llvm.c | 2 ++<br>
 1 file changed, 2 insertions(+)<br>
<br>
diff --git a/src/amd/common/ac_nir_to_llv<wbr>m.c b/src/amd/common/ac_nir_to_llv<wbr>m.c<br>
index e4ae6ef49ad..08ee81611e3 100644<br>
--- a/src/amd/common/ac_nir_to_llv<wbr>m.c<br>
+++ b/src/amd/common/ac_nir_to_llv<wbr>m.c<br>
@@ -1276,6 +1276,8 @@ static LLVMValueRef build_tex_intrinsic(struct ac_nir_context *ctx,<br>
                args->opcode = args->level_zero ||<br>
                               instr->sampler_dim == GLSL_SAMPLER_DIM_MS ?<br>
                                        ac_image_load : ac_image_load_mip;<br>
+               if (!args->lod)<br>
+                       args->lod = ctx->ac.i32_0;<br>
                args->level_zero = false;<br>
                break;<br>
        case nir_texop_txs:<br>
<span class="m_-9014741262092314511HOEnZb"><font color="#888888">-- <br>
2.17.0<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org" target="_blank">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>
</div></div></blockquote></div><br></div></div></div></div>