<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>> </div><div class="gmail_extra"> <div class="gmail_quote">On Mon, Apr 30, 2018 at 7:18 AM, Iago Toral Quiroga <<a href="mailto:itoral@igalia.com" target="_blank">itoral@igalia.com</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">These are not supported in hardware for 16-bit integers. We do the lowering pass after the optimization loop to ensure that we lower ALU operations injected by algebraic optimizations too. --- src/intel/compiler/brw_nir.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/src/intel/compiler/brw_nir.c b/src/intel/compiler/brw_nir.c index 16b0d86814..fb5e08fb33 100644 --- a/src/intel/compiler/brw_nir.c +++ b/src/intel/compiler/brw_nir.c @@ -590,6 +590,25 @@ brw_nir_optimize(nir_shader *nir, const struct brw_compiler *compiler, return nir; } +static unsigned +lower_bit_size_callback(const nir_alu_instr *alu, void *data) +{ + assert(alu->dest.dest.is_ssa); + if (alu->dest.dest.ssa.bit_size != 16) + return 0; + + switch (alu->op) { + case nir_op_idiv: + case nir_op_imod: + case nir_op_irem: + case nir_op_udiv: + case nir_op_umod: + return 32; + default: + return 0; + } +} + /* Does some simple lowering and runs the standard suite of optimizations * * This is intended to be called more-or-less directly after you get the @@ -643,6 +662,8 @@ brw_preprocess_nir(const struct brw_compiler *compiler, nir_shader *nir) nir = brw_nir_optimize(nir, compiler, is_scalar); + nir_lower_bit_size(nir, lower_bit_size_callback, NULL); + if (is_scalar) { OPT(nir_lower_load_const_to_scalar); } -- 2.14.1 </blockquote></div> </div>