<div dir="ltr"><div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div>Have I reviewed everything?  Can we land shaderInt16 now?<br><br></div>--Jason<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 2, 2018 at 5:18 PM, Jose Maria Casanova Crespo <span dir="ltr"><<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">---<br>
 src/intel/compiler/brw_shader.<wbr>cpp | 6 ++++--<br>
 1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_<wbr>shader.cpp b/src/intel/compiler/brw_<wbr>shader.cpp<br>
index 284c2e8233c..537defd05d9 100644<br>
--- a/src/intel/compiler/brw_<wbr>shader.cpp<br>
+++ b/src/intel/compiler/brw_<wbr>shader.cpp<br>
@@ -605,7 +605,8 @@ brw_negate_immediate(enum brw_reg_type type, struct brw_reg *reg)<br>
    case BRW_REGISTER_TYPE_V:<br>
       assert(!"unimplemented: negate UV/V immediate");<br>
    case BRW_REGISTER_TYPE_HF:<br>
-      assert(!"unimplemented: negate HF immediate");<br>
+      reg->ud ^= 0x80008000;<br>
+      return true;<br>
    case BRW_REGISTER_TYPE_NF:<br>
       unreachable("no NF immediates");<br>
    }<br>
@@ -651,7 +652,8 @@ brw_abs_immediate(enum brw_reg_type type, struct brw_reg *reg)<br>
    case BRW_REGISTER_TYPE_V:<br>
       assert(!"unimplemented: abs V immediate");<br>
    case BRW_REGISTER_TYPE_HF:<br>
-      assert(!"unimplemented: abs HF immediate");<br>
+      reg->ud &= ~0x80008000;<br>
+      return true;<br>
    case BRW_REGISTER_TYPE_NF:<br>
       unreachable("no NF immediates");<br>
    }<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.14.3<br>
<br>
</font></span></blockquote></div><br></div>