<html><head></head><body><div>On Thu, 2018-05-03 at 08:39 +0200, Iago Toral wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>On Wed, 2018-05-02 at 17:57 -0700, Jason Ekstrand wrote:</div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div><div>Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br><br></div>Have I reviewed everything? Can we land shaderInt16 now?<br></div></div></blockquote><div><br></div><div><br></div><div>Yes, all patches are reviewed now, thanks Jason.</div><div>I'll send the final set of patches to Jenkins one last time and push them today if we don't see any unexpected results.</div></blockquote><div><br></div><div>I have just pushed the patches to master.</div><div><br></div><div>Iago</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div>Iago</div><div><br></div><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex"><div dir="ltr"><div></div>--Jason<br></div><div class="gmail_extra"><br><div class="gmail_quote">On Wed, May 2, 2018 at 5:18 PM, Jose Maria Casanova Crespo <span dir="ltr"><<a href="mailto:jmcasanova@igalia.com" target="_blank">jmcasanova@igalia.com</a>></span> wrote:<br><blockquote type="cite" style="margin:0 0 0 .8ex; border-left:2px #729fcf solid;padding-left:1ex">---<br>
src/intel/compiler/brw_shader.cpp | 6 ++++--<br>
1 file changed, 4 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/src/intel/compiler/brw_shader.cpp b/src/intel/compiler/brw_shader.cpp<br>
index 284c2e8233c..537defd05d9 100644<br>
--- a/src/intel/compiler/brw_shader.cpp<br>
+++ b/src/intel/compiler/brw_shader.cpp<br>
@@ -605,7 +605,8 @@ brw_negate_immediate(enum brw_reg_type type, struct brw_reg *reg)<br>
case BRW_REGISTER_TYPE_V:<br>
assert(!"unimplemented: negate UV/V immediate");<br>
case BRW_REGISTER_TYPE_HF:<br>
- assert(!"unimplemented: negate HF immediate");<br>
+ reg->ud ^= 0x80008000;<br>
+ return true;<br>
case BRW_REGISTER_TYPE_NF:<br>
unreachable("no NF immediates");<br>
}<br>
@@ -651,7 +652,8 @@ brw_abs_immediate(enum brw_reg_type type, struct brw_reg *reg)<br>
case BRW_REGISTER_TYPE_V:<br>
assert(!"unimplemented: abs V immediate");<br>
case BRW_REGISTER_TYPE_HF:<br>
- assert(!"unimplemented: abs HF immediate");<br>
+ reg->ud &= ~0x80008000;<br>
+ return true;<br>
case BRW_REGISTER_TYPE_NF:<br>
unreachable("no NF immediates");<br>
}<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.14.3<br>
<br>
</font></span></blockquote></div><br></div>
</blockquote></blockquote></body></html>