<div dir="ltr">Reviewed-by: Jason Ekstrand <<a href="mailto:jason@jlekstrand.net">jason@jlekstrand.net</a>><br></div><div class="gmail_extra"><br><div class="gmail_quote">On Mon, May 7, 2018 at 1:51 PM, Caio Marcelo de Oliveira Filho <span dir="ltr"><<a href="mailto:caio.oliveira@intel.com" target="_blank">caio.oliveira@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Series is<br>
<br>
Reviewed-by: Caio Marcelo de Oliveira Filho <<a href="mailto:caio.oliveira@intel.com">caio.oliveira@intel.com</a>><br>
<div class="HOEnZb"><div class="h5"><br>
<br>
On Mon, May 07, 2018 at 01:40:44PM -0700, Kenneth Graunke wrote:<br>
> Python's assert can take both a condition and a string, which will cause<br>
> it to print the string if the assertion trips. (You can't use parens as<br>
> that creates a tuple.) Doing "condition and string" works in C, but<br>
> doesn't have the desired effect in Python.<br>
> ---<br>
> src/intel/genxml/gen_pack_<wbr>header.py | 2 +-<br>
> 1 file changed, 1 insertion(+), 1 deletion(-)<br>
> <br>
> diff --git a/src/intel/genxml/gen_pack_<wbr>header.py b/src/intel/genxml/gen_pack_<wbr>header.py<br>
> index 6a4c8033a70..4bce425d12e 100644<br>
> --- a/src/intel/genxml/gen_pack_<wbr>header.py<br>
> +++ b/src/intel/genxml/gen_pack_<wbr>header.py<br>
> @@ -220,7 +220,7 @@ def num_from_str(num_str):<br>
> if num_str.lower().startswith('<wbr>0x'):<br>
> return int(num_str, base=16)<br>
> else:<br>
> - assert(not num_str.startswith('0') and 'octals numbers not allowed')<br>
> + assert not num_str.startswith('0'), 'octals numbers not allowed'<br>
> return int(num_str)<br>
> <br>
> class Field(object):<br>
> -- <br>
> 2.17.0<br>
> <br>
> ______________________________<wbr>_________________<br>
> mesa-dev mailing list<br>
> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</div></div></blockquote></div><br></div>