<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Mon, May 7, 2018 at 11:44 PM, Kenneth Graunke <<a href="mailto:kenneth@whitecape.org" target="_blank">kenneth@whitecape.org</a>> wrote: <blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On Monday, May 7, 2018 12:49:32 PM PDT Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/gen7_misc_state.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/gen7_misc_state.c b/src/mesa/drivers/dri/i965/gen7_misc_state.c > index 1ce7658..1508473 100644 > --- a/src/mesa/drivers/dri/i965/gen7_misc_state.c > +++ b/src/mesa/drivers/dri/i965/gen7_misc_state.c > @@ -195,7 +195,8 @@ const struct brw_tracked_state gen7_depthbuffer = { > .mesa = _NEW_BUFFERS | > _NEW_DEPTH | > _NEW_STENCIL, > - .brw = BRW_NEW_BATCH | > + .brw = BRW_NEW_AUX_STATE | > + BRW_NEW_BATCH | > BRW_NEW_BLORP, > }, > .emit = brw_emit_depthbuffer, > Changes like this warrant an explanation - is this fixing any known issues? Found by inspection? I was surprised to see this, as BRW_NEW_AUX_STATE is usually about color surfaces - CCS_E compression, CCS_D fast clears...not HiZ. But I see that intel_miptree_make_shareable might deal with HiZ...as does depth clear values...as does set_aux_state...so it certainly seems plausible. Still, I'm curious to know if you were thinking of anything specific. </blockquote></div> </div><div class="gmail_extra">No, I don't know of anything specific. I found it while I was working on the rest of this series and thought it seemed off. In particular, if we do a trivial depth clear clear (which doesn't actually clear but just changes the clear color), we may not get 3DSTATE_CLEAR_PARAMS updated. </div></div>