<div dir="ltr"><div class="gmail_extra"><div class="gmail_quote">On Tue, May 15, 2018 at 10:42 PM, Tapani Pälli <span dir="ltr"><<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Patch changes entrypoints generator to not skip this extension even<br>
though it is set as disabled in the xml. We also need compilation<br>
flag VK_USE_PLATFORM_ANDROID_KHR to be enabled and a small fix to<br>
vk_icd.h because of following compilation error:<br>
<br>
vk_icd.h:116:5: error: must use 'struct' tag to refer to type 'ANativeWindow'<br>
<br>
It looks like this extension got disabled in commit 69f447553c.<br>
<br>
Signed-off-by: Tapani Pälli <<a href="mailto:tapani.palli@intel.com">tapani.palli@intel.com</a>><br>
---<br>
<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> | 1 +<br>
include/vulkan/vk_icd.h | 2 +-<br>
src/intel/vulkan/anv_<wbr>entrypoints_gen.py | 5 ++++-<br>
3 files changed, 6 insertions(+), 2 deletions(-)<br>
<br>
diff --git a/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a> b/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a><br>
index e8aed48c31..999e17789b 100644<br>
--- a/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a><br>
+++ b/<a href="http://Android.common.mk" rel="noreferrer" target="_blank">Android.common.mk</a><br>
@@ -73,6 +73,7 @@ LOCAL_CFLAGS += \<br>
-DHAVE_ENDIAN_H \<br>
-DHAVE_ZLIB \<br>
-DMAJOR_IN_SYSMACROS \<br>
+ -DVK_USE_PLATFORM_ANDROID_KHR \<br>
-fvisibility=hidden \<br>
-Wno-sign-compare<br>
<br>
diff --git a/include/vulkan/vk_icd.h b/include/vulkan/vk_icd.h<br>
index 7b54fb5774..77709c9f8d 100644<br>
--- a/include/vulkan/vk_icd.h<br>
+++ b/include/vulkan/vk_icd.h<br>
@@ -113,7 +113,7 @@ typedef struct {<br>
<br>
#ifdef VK_USE_PLATFORM_ANDROID_KHR<br>
typedef struct {<br>
- ANativeWindow* window;<br>
+ struct ANativeWindow* window;<br></blockquote><div><br></div><div>Please submit a PR against the Vulkan-LoaderAndValidationLayers for this. I belive the core issue is that we're including it from C whereas most people are using C++.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
} VkIcdSurfaceAndroid;<br>
#endif //VK_USE_PLATFORM_ANDROID_KHR<br>
<br>
diff --git a/src/intel/vulkan/anv_<wbr>entrypoints_gen.py b/src/intel/vulkan/anv_<wbr>entrypoints_gen.py<br>
index d603ac1b20..53ffbe30b9 100644<br>
--- a/src/intel/vulkan/anv_<wbr>entrypoints_gen.py<br>
+++ b/src/intel/vulkan/anv_<wbr>entrypoints_gen.py<br>
@@ -495,7 +495,10 @@ def get_entrypoints(doc, entrypoints_to_defines, start_index):<br>
if ext_name not in supported_exts:<br>
continue<br>
<br>
- if extension.attrib['supported'] != 'vulkan':<br>
+ # VK_ANDROID_native_buffer is set as 'disabled' but Mesa<br>
+ # supports it.<br>
+ if (extension.attrib['supported'] != 'vulkan' and<br>
+ ext_name != 'VK_ANDROID_native_buffer'):<br></blockquote><div><br></div><div>Is this continue even needed anymore? I honestly don't remember what it's here for.<br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
continue<br>
<br>
ext = supported_exts[ext_name]<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.14.3<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div></div>