<div dir="ltr"><div>As is evident from patches like this, this series is nowhere near ready for upstream. There's quite a bit of clean up work to do before it will be really ready to merge. I've been working on trying to clean up Francisco's original branch and sent out the first 19 ready-for-upstream patches on Friday: <a href="https://patchwork.freedesktop.org/series/43450/">https://patchwork.freedesktop.org/series/43450/</a> I intend to send more later this week once I get a couple of GPU hangs sorted out.</div><div><br></div><div>--Jason<br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Sun, May 20, 2018 at 8:29 PM, Shaofeng Tang <span dir="ltr"><<a href="mailto:shaofeng.tang@intel.com" target="_blank">shaofeng.tang@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">From: Kevin Rogovin <<a href="mailto:kevin.rogovin@intel.com">kevin.rogovin@intel.com</a>><br>
<br>
Change-Id: Ic5948415e0b4d6799b6a88ac507c1<wbr>999ccb1df39<br>
---<br>
src/intel/compiler/brw_fs.cpp | 6 +++++-<br>
1 file changed, 5 insertions(+), 1 deletion(-)<br>
<br>
diff --git a/src/intel/compiler/brw_fs.<wbr>cpp b/src/intel/compiler/brw_fs.<wbr>cpp<br>
index 121f9f8..b089b79 100644<br>
--- a/src/intel/compiler/brw_fs.<wbr>cpp<br>
+++ b/src/intel/compiler/brw_fs.<wbr>cpp<br>
@@ -3349,7 +3349,11 @@ fs_visitor::emit_repclear_<wbr>shader()<br>
<br>
assign_constant_locations();<br>
assign_curb_setup();<br>
- allocate_registers(16, false);<br>
+ /* WARNING: the original SIMD32 series has this line added, in patch<br>
+ * "i965/fs: Rework FB write header setup for SIMD32 and better scheduling."<br>
+ * but giving this line makes bad things happen later.<br>
+ */<br>
+ // allocate_registers(16, false);<br>
<br>
/* Now that we have the uniform assigned, go ahead and force it to a vec4. */<br>
if (uniforms > 0) {<br>
<span class="HOEnZb"><font color="#888888">-- <br>
2.7.4<br>
<br>
______________________________<wbr>_________________<br>
mesa-dev mailing list<br>
<a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br>
<a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br>
</font></span></blockquote></div><br></div>