<div dir="ltr">A related note on this:<div><br></div><div>Seems this file (<span style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:normal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">src/gallium/auxiliary/util/u_debug_stack_android.cpp</span>) doesn't make it into the tarballs (didn't for 18.1.0). Probably needs to be added to Makefile.source and meson.build somewhere so that building the tarball finds it. I checked for commits to both since 18.1.0 and saw nothing, so I suspect it's still missing (though not tested).</div><div><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On 1 June 2018 at 15:49, Mauro Rossi <span dir="ltr"><<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Hi there,<br><div class="gmail_extra"><br><div class="gmail_quote">2018-04-22 15:36 GMT+02:00 Stefan Schake <span dir="ltr"><<a href="mailto:stschake@gmail.com" target="_blank">stschake@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="m_79800659350641197HOEnZb"><div class="m_79800659350641197h5">On Sun, Apr 22, 2018 at 1:11 PM, Mauro Rossi <<a href="mailto:issor.oruam@gmail.com" target="_blank">issor.oruam@gmail.com</a>> wrote:<br> > Fix for build errors in src/gallium/auxiliary/util/u_d<wbr>ebug_stack_android.cpp<br> > error: cast to 'void *' from smaller integer type pid_t<br> ><br> > Fixes: ff904978a1 ("gallium/util: Android backtrace support")<br> ><br> > Cc: "18.1" <<a href="mailto:mesa-stable@lists.freedesktop.org" target="_blank">mesa-stable@lists.freedesktop<wbr>.org</a>><br> > ---<br> > src/gallium/auxiliary/util/u_d<wbr>ebug_stack_android.cpp | 4 ++--<br> > 1 file changed, 2 insertions(+), 2 deletions(-)<br> ><br> > diff --git a/src/gallium/auxiliary/util/u<wbr>_debug_stack_android.cpp b/src/gallium/auxiliary/util/u<wbr>_debug_stack_android.cpp<br> > index b3d56aebe6..11e2d3962b 100644<br> > --- a/src/gallium/auxiliary/util/u<wbr>_debug_stack_android.cpp<br> > +++ b/src/gallium/auxiliary/util/u<wbr>_debug_stack_android.cpp<br> > @@ -49,10 +49,10 @@ debug_backtrace_capture(debug_<wbr>stack_frame *mesa_backtrace,<br> > backtrace_table = _mesa_hash_table_create(NULL, _mesa_hash_pointer,<br> > _mesa_key_pointer_equal);<br> ><br> > - backtrace_entry = _mesa_hash_table_search(backtr<wbr>ace_table, (void*) tid);<br> > + backtrace_entry = _mesa_hash_table_search(backtr<wbr>ace_table, (void*)(uintptr_t) tid);<br> > if (!backtrace_entry) {<br> > backtrace = Backtrace::Create(getpid(), tid);<br> > - _mesa_hash_table_insert(backtr<wbr>ace_table, (void*) tid, backtrace);<br> > + _mesa_hash_table_insert(backtr<wbr>ace_table, (void*)(uintptr_t) tid, backtrace);<br> > } else {<br> > backtrace = (Backtrace *) backtrace_entry->data;<br> > }<br> > --<br> > 2.14.1<br> ><br> <br> </div></div>Sorry, I'm doing ARMv7/32-bit builds so this slipped through.<br> <br> Reviewed-By: Stefan Schake <<a href="mailto:stschake@gmail.com" target="_blank">stschake@gmail.com</a>><br> <br> Thanks!<br></blockquote><div><br></div><div>May I ask a second review by for intel x86 based platforms to Emil or other developer in Cc: ?<br></div><div>Thanks</div><span class="HOEnZb"><font color="#888888"><div><br></div><div>Mauro</div></font></span></div></div><div class="gmail_extra"><br></div></div> <br>______________________________<wbr>_________________<br> mesa-dev mailing list<br> <a href="mailto:mesa-dev@lists.freedesktop.org">mesa-dev@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/mesa-dev" rel="noreferrer" target="_blank">https://lists.freedesktop.org/<wbr>mailman/listinfo/mesa-dev</a><br> <br></blockquote></div><br><br clear="all"><div><br></div>-- <br><div class="gmail_signature" data-smartmail="gmail_signature">Stuart Young (aka Cefiar)</div> </div>